picasa plugin broken in php5

Creating and modifying plugins.
Post Reply
greenwayg
Regular
Posts: 34
Joined: Wed Jan 02, 2008 8:25 pm

picasa plugin broken in php5

Post by greenwayg »

My webmaster just upgraded from php4 to php5, and the picasa plugin started failing because it couldn't load the domxml extension. I did some research, and it appears the domxml extension was experimental in php4, and was not carried forward to php5.

So to fix my blog, I rewrote all of the xml parsing using expat, which I believe is almost always available in any version of php. The code isn't as pretty, but it is probably faster, and it should work on more server configurations.

The code can be retrieved from http://www.wreck.org/~greg/xmlParserFix ... sa.php.txt. However, this version also has all of my changes related to the thread at http://board.s9y.org/viewtopic.php?f=4&t=15918&start=15. If needed, I can provide separated diffs of the different changes. Garvin, can you put this into revision control (and review it)?

thanks,
greg
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: picasa plugin broken in php5

Post by garvinhicking »

Hi!

Great, thanks, I committed it. I believe you also added new language strings, can you get the lang_en.inc.php file to me? Any other files needing updates?

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: picasa plugin broken in php5

Post by garvinhicking »

Hi!

Nevermind, just found them one dir higher, committed!

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply