expose_s9y not used systemwide

[jemm4jemm]

There is and useful feature in serendipity_config.inc.php - through expose_s9y you can manage how explicitly Serendipity tells the world its version.

This works pretty fine, except in feeds accessed though /feeds/... urls. Therein in <generator> tag the blogengine version is still shown even if expose_s9y is set to false.

[garvinhicking]

Hi!

Yes, that is true, because this is a place where every blog software does expose itself. We do not want to strip this. If you absolutely must, you can create your own feed template.

But this is one of the places where you can pay your credits for a wonderful open source software.

Regards,
Garvin

[jemm4jemm]

Yes, that is true, because this is a place where every blog software does expose itself. We do not want to strip this. If you absolutely must, you can create your own feed template.

No trouble in the promotion of the blogengine, but the issue is in version number.

So
<generator>Serendipity - 1.3 http://www.s9y.org/</generator>
should be
<generator>Serendipity - http://www.s9y.org/</generator>
if expose_s9y is set to false.

The same way as if expose_s9y is set to false then footer in login page is
Powered by Serendipity and PHP
instead of
Powered by Serendipity 1.3 and PHP 5.2.5

[garvinhicking]

Hi!

Ah, of course, now I see.

I've just committed a patch that will omit the version number when expose_s9y is disabled.

Regards,
Garvin

[jemm4jemm]

I've just committed a patch that will omit the version number when expose_s9y is disabled.

Thanks. Also many security-conscious server-owners will be thankful

[jemm4jemm]

I've just committed a patch that will omit the version number when expose_s9y is disabled.

Can you do the same for emails sent from s9y.

With expose_s9y set as false then mail header should be:
X-Mailer: Serendipity
but is now:
X-Mailer: Serendipity/1.3

[garvinhicking]

Hi!

Very good, thanks & fixed

Regards,
Garvin