Getting logged out in admin, Sessions bug?

Found a bug? Tell us!!
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi Shadowin!

Wow, you're help is awesome. It does definitely make sense.

It seems IIS sets "HTTPS" to "off", but usually a webserver should keep it empty. The PHP doc says:

Code: Select all

'HTTPS'
    Set to a non-empty value if the script was queried through the HTTPS protocol. 
I committed your patch to our sourcecode, and it will be part of an upcoming release!

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Shadowin
Regular
Posts: 6
Joined: Thu Jan 04, 2007 4:40 am
Location: Columbia, SC, USA
Contact:

More Info

Post by Shadowin »

Thanks Gavin.

It definitely appears to be an IIS only issue.

I checked all the other code out and I didn't see performing checks like that in any other place. However, the check is performed in several different files in several different ways. I think it'd be a good idea to stick to one standard way of doing it.

If there's any room on the dev team, I will sign up and help out.
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: More Info

Post by garvinhicking »

Hi Shadowin!

I just published this blog post: http://blog.s9y.org/archives/160-Serend ... s-IIS.html

So many thanks for fixing this issue! Indeed your help in the dev-team would be a great thing. If you like, you could prepare a unification patch that I could commit? Usually we first take 2-3 patches from new developers before we hand out SVN write access, if that's fine with you.

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Jorick
Posts: 4
Joined: Wed Jul 12, 2006 4:31 pm
Location: Leusden [NL]
Contact:

Post by Jorick »

Whoohoo! :D :D

It works again! Thanks for your help. I'm using S9Y since August 2006, and I must say: it's really good!

I hope I can help other people in the future too! :)

Good night,

Jorick
kharri1073
Regular
Posts: 15
Joined: Tue May 09, 2006 6:01 pm
Contact:

Post by kharri1073 »

Wow thats it!! Thanks so much!
dk70
Regular
Posts: 19
Joined: Sat Aug 13, 2005 9:53 am

Post by dk70 »

Yep, works now - thanks Shadowin. Awesome if IIS issues can be attacked faster in future.
Post Reply