Hi!
When using Clean Blog, the top menu bar hovers at the top of the window when scrolling down, as ist should.
But when I scroll up again, the menu bar "hangs" too low, covering some of the content while more content above it is still visible, instead of clinging to the top of the window.
Example page: http://kunz-artenschutz.de/index.php?/vita.html
Screenshot:
Clean Blog: Top Menu floating in content
Clean Blog: Top Menu floating in content
Post-apocalyptic Jugger sports: What is Jugger? Video I Free ebook on the sport
Re: Clean Blog: Top Menu floating in content
Not a solution tet, observation: When you scroll up the JS sets .is-visible to the navbar (.navbar-custom). This adds a transform:
Disabling those transforms fixes the buggy behaviour (under Firefox).
Solution: Unclear, maybe the bulletproof version can be updated without too much work and would fix this? Otherwise the theme's javascript could be changed to not add .is-visible, but I assume it gets set for a reason?
Code: Select all
@media only screen and (min-width: 1170px) {
.navbar-custom.is-visible {
-webkit-transform: translate3d(0, 100%, 0);
-moz-transform: translate3d(0, 100%, 0);
-ms-transform: translate3d(0, 100%, 0);
-o-transform: translate3d(0, 100%, 0);
transform: translate3d(0, 100%, 0);
}
}Solution: Unclear, maybe the bulletproof version can be updated without too much work and would fix this? Otherwise the theme's javascript could be changed to not add .is-visible, but I assume it gets set for a reason?
Re: Clean Blog: Top Menu floating in content
Hi!
Sorry I was away. Thanks for your suggestion! I applied the fix you mentioned, and the menu now stays on top of the visible content. Yet if I try to prevent it from scrolling down with the content, I couldn't find a solution through css (position: fixed doesn't do the trick).
Sorry I was away. Thanks for your suggestion! I applied the fix you mentioned, and the menu now stays on top of the visible content. Yet if I try to prevent it from scrolling down with the content, I couldn't find a solution through css (position: fixed doesn't do the trick).
Post-apocalyptic Jugger sports: What is Jugger? Video I Free ebook on the sport
Re: Clean Blog: Top Menu floating in content
Hi, I just merged a bigger update of the clean-blog theme, at https://github.com/s9y/Serendipity/pull/923. Updates all the libraries used, including bootstrap. Bootstrap wasn't updated to the newest version, but it got some updates (the old v3 got some minor updates before it was replaced by v4, updates missing in clean blog so far). Maybe you want to test how the new version behaves in your blog / whether it fixes the floating menu :)
Re: Clean Blog: Top Menu floating in content
Great! Checking.
UPDATE: Feedback: Sadly, the menu still "lags" if I scroll down and up again – there's still a gap between the upper border of the window and the menu.
Strangely, I thought I did fix this using your suggestions ... which is interesting for they had been implemented in user.css. Has a class changed?
UPDATE 2: It is reported that the floating menu causes problems on smaller screens in terms of readability, e.g. smartphones and tablets.
UPDATE: Feedback: Sadly, the menu still "lags" if I scroll down and up again – there's still a gap between the upper border of the window and the menu.
Strangely, I thought I did fix this using your suggestions ... which is interesting for they had been implemented in user.css. Has a class changed?
UPDATE 2: It is reported that the floating menu causes problems on smaller screens in terms of readability, e.g. smartphones and tablets.
Post-apocalyptic Jugger sports: What is Jugger? Video I Free ebook on the sport
Re: Clean Blog: Top Menu floating in content
PS. Here we go with an example of the floating menu on smaller devices.
Post-apocalyptic Jugger sports: What is Jugger? Video I Free ebook on the sport
Re: Clean Blog: Top Menu floating in content
That really looks bad. I put too much time into modernizing the theme, I will check on this as well.
Re: Clean Blog: Top Menu floating in content
Wonderful, thanks!
Post-apocalyptic Jugger sports: What is Jugger? Video I Free ebook on the sport
Re: Clean Blog: Top Menu floating in content
Ok, the problem here seems to be that the theme does not expect such a wide link list. It then places the right part below the left, which leads to that strange placement when scrolling up. I think I found a simple fix: In templates/clean-blog/style.css, line 138, replace
with
Also as a PR at https://github.com/s9y/Serendipity/pull/939. Please give this a test run, if it works we can fix it in master :)
Side note: On small devices, the theme disables the floating menu completely, there is no fixed header then as far as I could see. That would be the next thing to work on if this fix does not repair it accidentally as well.
Code: Select all
.navbar-custom.is-visible {
/* if the user changes the scrolling direction, we show the header */
-webkit-transform: translate3d(0, 100%, 0);
-moz-transform: translate3d(0, 100%, 0);
-ms-transform: translate3d(0, 100%, 0);
-o-transform: translate3d(0, 100%, 0);
transform: translate3d(0, 100%, 0);
}Code: Select all
.navbar-custom.is-visible {
/* if the user changes the scrolling direction, we show the header */
top: 0;
}Side note: On small devices, the theme disables the floating menu completely, there is no fixed header then as far as I could see. That would be the next thing to work on if this fix does not repair it accidentally as well.
Re: Clean Blog: Top Menu floating in content
Hi,
this seems to fix the issue. Thanks!
this seems to fix the issue. Thanks!
Post-apocalyptic Jugger sports: What is Jugger? Video I Free ebook on the sport
Re: Clean Blog: Top Menu floating in content
Okay, I will merge this. Thanks for testing the patch so fast, and please let me know if you see issues with this solution later.