Overriding commentInfo['ip']?

[FishNiX]

Hey all -

I'm trying to write in support for X-Forwarded-For without hacking core functions. I've been trying to work with the frontend_saveComment event hook. It looks like eventData and addData come through with some information about the comment, but setting

Code: Select all

eventData['ip'] = getenv('HTTP_X_FORWARDED_FOR') != '' ? getenv('HTTP_X_FORWARDED_FOR') : $_SERVER['REMOTE_ADDR'];

or

Code: Select all

addData['ip'] = getenv('HTTP_X_FORWARDED_FOR') != '' ? getenv('HTTP_X_FORWARDED_FOR') : $_SERVER['REMOTE_ADDR'];

doesn't override commentInfo. I'm not sure if this is possible? I don't really want to hack include/functions_comments.inc.php if I don't have to since it will make upgrades, etc harder.

Thanks!

[garvinhicking]

Hi!

Have you tried editing your serendipity_config_local.inc.php with somethin glike this:

Code: Select all

if (getenv('HTTP_X_FORWARDED_FOR') != '') {
  $_SERVER['REMOTE_ADDR'] = getenv('HTTP_X_FORWARDED_FOR');
}

then you shouldn't need to patch any code, because the proper IP you want is always contained in the right variable that everything accesses?

Regards,
Garvin

[FishNiX]

I didn't know I could do that. I'll give it a shot.

Thanks as always!
-c