Diff for identi.ca in serendipity_event_findmore

Creating and modifying plugins.
Post Reply
User avatar
seraphyn
Regular
Posts: 211
Joined: Fri Dec 01, 2006 8:42 am
Contact:

Diff for identi.ca in serendipity_event_findmore

Post by seraphyn » Tue May 31, 2011 10:28 am

plugin_findmore.tpl:

Code: Select all

8,12d7
< 
< {if NOT $findmore_disabled_services.identica}
< <a href="http://identi.ca/notice/new?status_textarea={$entrydata.title|escape:url}%20-%20{$entrydata.url|escape:url}" title=Identi.ca"><img src="{$entrydata.path}identica.png" title="Identi.ca" alt="Identi.ca" class="socialbkmark" /></a>
< {/if}
< 
serendipity_event_findmore.php

Code: Select all

76a77
>                         'identica'       => 'Identi.ca',
Identi.ca-Pic attached
Attachments
identica.png
Identica Picture
identica.png (464 Bytes) Viewed 3902 times

User avatar
garvinhicking
Core Developer
Posts: 30020
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Diff for identi.ca in serendipity_event_findmore

Post by garvinhicking » Wed Jun 01, 2011 10:28 am

Hi!

Great! Added to CVS.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
seraphyn
Regular
Posts: 211
Joined: Fri Dec 01, 2006 8:42 am
Contact:

Re: Diff for identi.ca in serendipity_event_findmore

Post by seraphyn » Fri Jun 10, 2011 6:53 pm

Hi Garvin,

one Error:

[quote="seraphyn"]plugin_findmore.tpl:

Code: Select all

8,12d7
< 
< {if NOT $findmore_disabled_services.identica}
< <a href="http://identi.ca/notice/new?status_textarea={$entrydata.title|escape:url}%20-%20{$entrydata.url|escape:url}" title=Identi.ca"><img src="{$entrydata.path}identica.png" title="Identi.ca" alt="Identi.ca" class="socialbkmark" /></a>
< {/if}
< 
title =identi.ca" is wrong.
There should be an ".
Did you need a new diff?

chris

User avatar
seraphyn
Regular
Posts: 211
Joined: Fri Dec 01, 2006 8:42 am
Contact:

Re: Diff for identi.ca in serendipity_event_findmore

Post by seraphyn » Fri Jun 10, 2011 7:06 pm

Garinv,

diff including the wrong set in twitter for rel="nofollow" and identi.ca wrong title:
plugin_findmore.tpl:

Code: Select all

5c5
< <a  rel="nofollow" href="http://twitter.com/home?status={$entrydata.title|escape}%20-%20{$entrydata.url|escape:url}" title="Twitter"><img src="{$entrydata.path}twitter.png" title="Twitter" alt="Twitter" class="socialbkmark" /></a>
---
> <a href="http://twitter.com/home?status={$entrydata.title|escape}%20-%20{$entrydata.url|escape:url}" title="Twitter"><img src="{$entrydata.path}twitter.png" title="Twitter" alt="Twitter" rel="nofollow" class="socialbkmark" /></a>
105c105
< <a rel="nofollow" href="http://identi.ca/notice/new?status_textarea={$entrydata.title|escape:url}%20-%20{$entrydata.url|escape:url}" title="Identi.ca"><img src="{$entrydata.path}identica.png" title="Identi.ca" alt="Identi.ca" class="socialbkmark" /></a>
---
> <a rel="nofollow" href="http://identi.ca/notice/new?status_textarea={$entrydata.title|escape:url}%20-%20{$entrydata.url|escape:url}" title=Identi.ca"><img src="{$entrydata.path}identica.png" title="Identi.ca" alt="Identi.ca" class="socialbkmark" /></a>

User avatar
garvinhicking
Core Developer
Posts: 30020
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Diff for identi.ca in serendipity_event_findmore

Post by garvinhicking » Sat Jun 11, 2011 10:49 am

Hi!

I changed the missing " for identica. I don't understand what's with the Twitter change? rel=nofollow is already there?!?

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
seraphyn
Regular
Posts: 211
Joined: Fri Dec 01, 2006 8:42 am
Contact:

Re: Diff for identi.ca in serendipity_event_findmore

Post by seraphyn » Sat Jun 11, 2011 11:00 am

rel=nofollow is for the img source and not for the link.
<img src="{$entrydata.path}twitter.png" title="Twitter" alt="Twitter" rel="nofollow"
but it have to be
<a rel="nofollow" href="http://twitter.com/home?status={$entryd ... escape:url}"
So this works with validator from w3c too and have more sense
Chris

User avatar
garvinhicking
Core Developer
Posts: 30020
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Diff for identi.ca in serendipity_event_findmore

Post by garvinhicking » Sun Jun 12, 2011 12:33 pm

Hi!

ah sorry! Now I see! Also committed. :)
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
seraphyn
Regular
Posts: 211
Joined: Fri Dec 01, 2006 8:42 am
Contact:

Re: Diff for identi.ca in serendipity_event_findmore

Post by seraphyn » Sun Jun 12, 2011 12:50 pm

You're welcome.
Thanks
Have a nice Weekend and Pfingsten
Chris

Marit321
Regular
Posts: 5
Joined: Tue Aug 23, 2011 12:23 pm

Re: Diff for identi.ca in serendipity_event_findmore

Post by Marit321 » Tue Sep 20, 2011 1:37 pm

Hi,
why do you use rel=nofollow for the img source ?
<a rel="nofollow" href="http://twitter.com/home?status={$entryd ... escape:url}"
Thank´s
Marit


------------------------------------
my sites: Private Krankenversicherung
Private Krankenversicherung Vergleich
Last edited by Marit321 on Tue Sep 20, 2011 4:49 pm, edited 1 time in total.

User avatar
seraphyn
Regular
Posts: 211
Joined: Fri Dec 01, 2006 8:42 am
Contact:

Re: Diff for identi.ca in serendipity_event_findmore

Post by seraphyn » Tue Sep 20, 2011 1:53 pm

Not for img-source, for the link.
Read above

Post Reply