improvement: bundled-libs/HTTP/Request.php

Discussion corner for Developers of Serendipity.
Post Reply
twobee
Regular
Posts: 19
Joined: Thu May 18, 2006 8:02 pm
Location: Berlin
Contact:

improvement: bundled-libs/HTTP/Request.php

Post by twobee »

and again in line 18 :)

find

Code: Select all

        $separator = ini_get('arg_separator.output');
        ini_set('arg_separator.output', '&');
        $querystring = ($querystring = $this->_url->getQueryString()) ? '?' . $querystring : '';
        ini_set('arg_separator.output', $separator);
and replace with

Code: Select all

if (function_exists('ini_set')
    {
        $separator = ini_get('arg_separator.output');
        ini_set('arg_separator.output', '&');
        $querystring = ($querystring = $this->_url->getQueryString()) ? '?' . $querystring : '';
        ini_set('arg_separator.output', $separator);
    }
it also works without the replacement, or better it worked on my server. The change is only to inhibit any error messages.


p.s.: Yes, I do have a very restrictive php.ini ;)

regards,

twobee
-=( Experienced Apache 2.0.x Administrator )=-
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: improvement: bundled-libs/HTTP/Request.php

Post by garvinhicking »

Hi!

We try to not creat forked/branched versions of foreign APis like PEAR HTTP:Request. So please try to get your patch committed to the official PEAR package, and then we can upgrade to the latest one. :)

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply