Serendipity Forums

[garvinhicking]

looks like you are good in pestering too
...mine is shorter, but that one looks very professional! Its up to you.

I didn't yet understand your solution? I only saw a php include of a .tpl file? But that would mean converting the .tpl file to PHP first?

So I think Rodneys solution should be used in case of non-writable directory...

Regards,
Garvin

[Timbalu]

I didn't yet understand your solution? I only saw a php include of a .tpl file? But that would mean converting the .tpl file to PHP first?

No. Have a deeper look at the commit. I got it working with that 'resource' eval display call and the && IN_installer !== true. Even tested with the YL prototype. No register necessary in my opinion, since used in this particular place (installer - step 1) only. I found Smarty well coded, as it seems no internal writable check is done, if using this resource eval display call.

So I think Rodneys solution should be used in case of non-writable directory...

As I said, its up to you.

[garvinhicking]

Hi!

Ah, okay. WEll, if it works, we keep your solution. if there are problems at some point we can still try rodneys.

Regards,
Garvin

[yellowled]

I just tried to install a new dev blog based on a fresh 2.0 checkout.

Fatal error: Cannot redeclare serendipity_db_update() (previously declared in /foo/bar/include/db/db.inc.php:27) in /foo/bar/include/db/db.inc.php on line 56

after step 2b, i.e. fill out all the data needed for the installation. Any clues?

YL

[Timbalu]

Hmmm, I do not have that. (I ran a test):
- Are you sure using the latest 2.0 and installer.inc? Maybe you have some other old files?
- Is this some kind of special server setup?
In functions_installer.inc.php around line 728 you can find two include_once calls. If you still have this problem... try replacing them with require_once.

Please also update installer.inc, as I just fixed an error with installation errors.
Replace head of new installer.inc.tpl with this:

Code: Select all

{* HTML5: Yes *}
{* From configuration to install *}
{if $is_errors && is_array($errors)}
    {foreach $errors AS $error}
    <span class="msg_error">{$error}</span>
    {/foreach}
{/if}


[Timbalu]

Garvin, is it possible to check and error if InnoDB (as this is the default mysql table engine) is used before db installation is done?

[garvinhicking]

Garvin, is it possible to check and error if InnoDB (as this is the default mysql table engine) is used before db installation is done?

Hm? mysql_error() should return results, that could be used?

Regards,
Garvin

[Timbalu]

But there is no error, as InnoDB is totally valid in the mysql world and s9y installs correctly, but it is no good with some Serendipity tables itself later on. That is why it might be a good idea to check this before install.

[yellowled]

- Are you sure using the latest 2.0 and installer.inc? Maybe you have some other old files?
- Is this some kind of special server setup?

Yes, it is the latest 2.0. Not sure about the server setup, I'll run a local test install against it.

Code: Select all

{* HTML5: Yes *}
{* From configuration to install *}
{if $is_errors && is_array($errors)}
    {foreach $errors AS $error}
    <span class="msg_error">{$error}</span>
    {/foreach}
{/if}


What exactly is this supposed to replace? I have:

Code: Select all

{if $i_success}
    return '<span class="msg_success">'. $s .'</span>';
{/if}
{if $i_warning}
    return '<span class="msg_notice">'. $s .' [?]</span>';
{/if}
{if $i_error}
    return '<span class="msg_error">'. $s .' [!]</span>';
{/if}
{if ( sizeof($smarty.post) > 1 && $s9yGETstep == 3 )}
    {if is_array($errors)}
        {foreach $errors AS $error}
        <span class="msg_error">{$error}</span>
        {/foreach}
    {/if}
{/if}

YL

[yellowled]

What exactly is this supposed to replace?

Never mind, I just saw it in your latest 2.0 commit.

YL

[yellowled]

Not sure about the server setup, I'll run a local test install against it.

Hmmm. Worked fine on localhost, so it might be the remote server setup. Sorry.

YL

[Timbalu]

Would still be nice to find out..., as we had this (long time) before (viewtopic.php?f=1&t=3763).

[garvinhicking]

But there is no error, as InnoDB is totally valid in the mysql world and s9y installs correctly, but it is no good with some Serendipity tables itself later on. That is why it might be a good idea to check this before install.

Please explain in depth what you mean, I don't understand any of this.

Regards,
Garvin

[yellowled]

Would still be nice to find out..., as we had this (long time) before (viewtopic.php?f=1&t=3763).

I'm pretty sure it's some weird reaction to the server setup (I'll check with the hoster's support), but for the record: changing (@)include_once to (@)require_once does not help.

YL

[yellowled]

Just did a test install on the same host w/ 1.6 – still doesn't complete the installation. This has to be some hiccup with the server.

YL