serendipity_event_forgotpassword

[JWalker]

serendipity_event_forgotpassword:
Something that I think are buggs or improvement needs.

1) In the form that appears after 'Forgot pasword' is clicked: When the visitor enters username, that is not registered at all (nonexistent in DB) PLUGIN_EVENT_FORGOTPASSWORD_EMAIL_DB_ERROR message appears ('Cannot connect to Database'). In fact there is connection to the database but no such user is available. May be these two situations should be separated and two messages to appear : 'No such user' and 'Cannot connect to Database' ?

2) In the situation of no net/no internet, here are the messages that appear (and come from PHP).

[garvinhicking]

I've fixed that MB_send_mail error within the core s9y version, since the charset doesn'T seem to be encoded within double-quotes.

However, without a connection to the net, no mail can be sent. I think we can expect that serendipity is able to send a mail, but a "pretty error" would mabe be nice.

I'll leave that up to the plugin author, hope he's reading this.

Best regards,
Garvin

[JWalker]

I've fixed that MB_send_mail error within the core s9y version, since the charset doesn'T seem to be encoded within double-quotes.

My test installation was too old, may be a month or more. Today downloaded the last nighly.

However, without a connection to the net, no mail can be sent. I think we can expect that serendipity is able to send a mail, but a "pretty error" would mabe be nice.

Yes it sends mails, but tried to see what happens when there is no way to send - these "OS" messages are not pretty. May be the author reads this, indeed.

Regards

[oxygenws]

1) In the form that appears after 'Forgot pasword' is clicked: When the visitor enters username, that is not registered at all (nonexistent in DB) PLUGIN_EVENT_FORGOTPASSWORD_EMAIL_DB_ERROR message appears ('Cannot connect to Database'). In fact there is connection to the database but no such user is available. May be these two situations should be separated and two messages to appear : 'No such user' and 'Cannot connect to Database'?

Thanks JWalker.
i will fix that asap

May be the author reads this, indeed.

[oxygenws]

updated, could you test it please?

(i update it now, wait for CVS updates)

[JWalker]

tested:

It recognizes invalid userame and the new string PLUGIN_EVENT_FORGOTPASSWORD_USER_NOT_EXIST appears. Not tested with 'db connection is missing' but it appears it will work.

My configuration is on a single box: Apache+PHP+MySQL+database+Firefox browser. Mail SMTP is on another box in our intranet. Regarding this, when I tested with valid username and unplugged ethernet cable it does not find SMTP -- that is right. Here is the message that appears:

Code: Select all

Warning: mb_send_mail() [function.mb-send-mail]: Failed to connect to mailserver at "192.168.24.201" port 25, verify your "SMTP" and "smtp_port" setting in php.ini or use ini_set() in D:\biz\apps\s9y\include\functions.inc.php on line 403

This message is a result of PHP mail() call. (php.ini is OK). I don't know if this can be replaced with more user friednly message and if it can, where it should be done: in the plugin or in include/functions.inc.php.

Uploaded updated BG files just now.

[garvinhicking]

I think that error message is a good warning string that tells the user what is wrong, and it shouldn't ever happen on live blogs so I do think we could leave it that way...

$0.02

Regards,
Garvin

[oxygenws]

It recognizes invalid userame and the new string PLUGIN_EVENT_FORGOTPASSWORD_USER_NOT_EXIST appears.

those are Garvin changes (mine was wrong)
thanks Garv.

[JWalker]

I think that error message is a good warning string that tells the user what is wrong, and it shouldn't ever happen on live blogs so I do think we could leave it that way...

$0.02

Regards,
Garvin

Yes ... this is beyond s9y; the end user should not see this -- it is up to site administrator to get the blog working. 10x