serendipity_event_trackexits adds second title

[Thomas]

Hi,

today I continued developing my own theme and therefore I checked it with the HTML validator of the W3C.

Through that I found a minor problem with the core plugin serendipity_event_trackexits.

If you enable the exit counter also on HTML nuggets and use, for instance, the popular link code of Firefox:

Code: Select all

<a href="http://getfirefox.com/" title="Get Firefox - The Browser, Reloaded."><img src="http://www.mozilla.org/products/firefox/buttons/firefox_80x15.png" width="80" height="15" border="0" alt="Get Firefox"></a>

... then the final output is something like this:

Code: Select all

<a href="http://blog.benqo.net/exit.php?url=aHR0cDovL2dldGZpcmVmb3guY29tLw==" title="http://getfirefox.com/" onmouseover="window.status='http://getfirefox.com/';return true;" onmouseout="window.status='';return true;"  title="Get Firefox - The Browser, Reloaded."><img src="http://www.mozilla.org/products/firefox/buttons/firefox_80x15.png" width="80" height="15" border="0" alt="Get Firefox"></a>

Notice the second "title" in the anchor. This makes the validator to raise an error because of using an attribute twice.

Just for your info.

Regards, Thomas

P.S.: S9Y v.0.8.3 is in use.

[garvinhicking]

Yes, actually this plugin is less recognitive of already existing title/onmouseover/onmouseout tags. Since the involved RegEx magic is pretty wacky, I just committed a fix which is hopefully working.

Could you try it out?

http://svn.berlios.de/viewcvs/*checkout ... kexits.php

This is a 0.9 plugin, but it should work in 0.8.3 without problems.

Regards,
Garvin