We should not remove files via the upgrader
Posted: Tue Jun 16, 2015 9:47 pm
In the upgrader, we have a few tasks that remove files from serendipity. These are especially the files unter /htmlarea. I think that this is a problem, and it explains a few of the upgrade problems we saw.
1. If the upgrader fails to remove those files, it can happen that the upgrader fails completely. Just happend in my test-blog (from 2.0.2 to 2.1)
2. A good configured server should not give serendipity the rights to remove those files. They are not under /uploads or under /templates_c, not even under /templates.
The combination of these two points looks like a critical mistake on our side to me.
To see a list of the files to remove, see https://github.com/s9y/Serendipity/blob ... nc.php#L20
I think we should remove those upgrader tasks, especially those for 2.0 and newer versions. Garvin, what do you think?
1. If the upgrader fails to remove those files, it can happen that the upgrader fails completely. Just happend in my test-blog (from 2.0.2 to 2.1)
2. A good configured server should not give serendipity the rights to remove those files. They are not under /uploads or under /templates_c, not even under /templates.
The combination of these two points looks like a critical mistake on our side to me.
To see a list of the files to remove, see https://github.com/s9y/Serendipity/blob ... nc.php#L20
I think we should remove those upgrader tasks, especially those for 2.0 and newer versions. Garvin, what do you think?