I was correct in that bulletproof, and all of its decendants, use css to substitute the rss icons. Which actually now leads to a problem with subtome.
The subtome icon is also emitting the class .serendipity_xml_icon (in addition to serendipity_subtome). Bulletproof, and every template/colorset built on it (this could be a LOT) use the following technique to substitute the xml icon:
Code: Select all
.serendipity_xml_icon {
background: url('img/purple_xml.png') center center no-repeat;
padding: 10px 0;
margin: 0;
visibility: visible;
}
.serendipity_xml_icon img {
visibility: hidden;
}
So, if using bulletproof's purple colorset, or any derivative theme/colorset, the subtome icon looks like this:
1) I do not think the subtome icon should be emitting the .serendipity_xml_icon class. This is very easy to fix, and I can do it if no one objects.
2) I do not think the subtome icon should be used if the option to use subtome is false. If not using subtome, the icon should fall back to a standard rss icon (which the subtome icon is not).
3) The freetag plugin, and the comments rss icon, will use a template's /img/xml.gif if it exists, falling back down the template path hierarchy until it is found, presumably in 2k11. Before subtome, when we had a list all selected rss feeds, those icons worked this way too. I think subtome should be configured to work this way as well, using /img/subtome.png if it exists in the current template
4) The category plugin should also be modified to use a template's /img/xml.gif if it exists, and not hard coded to 2k11.
5) I would be more than happy to suggest xml.gif be changed to xml.png in all these cases, unless that creates problems for old themes. Gif died ages ago.
Thoughts?