Re: Extended Properties feature request
Posted: Sat Jan 31, 2015 4:49 pm
Here are my questions now that I have had a good look.
First, why did you change this:
to this?
I put that in there for a reason. Entry properties CAN be images, but frequently (and possibly more often) are something else. Emitting the caption "Preview" all the time is misleading, which is why my commit only emitted it when the value was determined to be an image. I strongly suggest restoring this.
Next, I like the new div structure a lot better than the former fieldset. Seems cleaner. Great job. So it was a max-width issue with Firefox? Not sure I have every run into an issue where firefox had a bug!
First, why did you change this:
Code: Select all
<?php if (preg_match('/(\.jpg|\.png|\.bmp)$/', $value)) { echo '<figcaption>' . PREVIEW . '</figcaption>'; }?>
Code: Select all
<?php echo '<figcaption>' . PREVIEW . '</figcaption>'; ?>
Next, I like the new div structure a lot better than the former fieldset. Seems cleaner. Great job. So it was a max-width issue with Firefox? Not sure I have every run into an issue where firefox had a bug!