Serendipity Forums

@Garvin

Could you please add @define('SIZE_SHORT', 'Size'); and @define('SIZE_SHORT', 'Größe'); for consistency to lang files in master and 2.0, please.

Timbalu wrote:@Garvin

Could you please add @define('SIZE_SHORT', 'Size'); and @define('SIZE_SHORT', 'Größe'); for consistency to lang files in master and 2.0, please.

What about IMAGE_SIZE and SORT_ORDER_SIZE? Ideally I'd like to use those instead of create new ones that do not exist in most translations already.

Regards,
Garvin

garvinhicking wrote:What about IMAGE_SIZE and SORT_ORDER_SIZE? Ideally I'd like to use those instead of create new ones that do not exist in most translations already.

Erm. We are going to need quite a few new lang constants for the new backend anyway. There's no way I am going to be able to implement the new backend the way it's supposed to be with the existing lang constants.

YL

garvinhicking wrote:

Timbalu wrote:What about IMAGE_SIZE and SORT_ORDER_SIZE? Ideally I'd like to use those instead of create new ones that do not exist in most translations already.

SORT_ORDER_SIZE (as media files can be more than images) would be fine with me... but, it is just the place where ORIGINAL_SHORT and THUMBNAIL_SHORT are used as siblings. That is why I thought a short "Size" would help to stay more consistency in look and feel (and might help in mobile views).

Hi!

YL: Well, words that exist in our current translations should be re-used.

I am only arguing for this specific instance where I feel an existing translation owuld be better. That could differ in new scenarios where the new media backend needs specific sentences with changes; there we can only add new strings of course.

The "addlang.sh" script is a very simple shell script to add new constants to every language file; it is written for Linux/OSX in mind (because it uses iconv), but it should be possible to use windows iconv.exe similarities within a Batch-file...

Best regards,
Garvin