@Garvin
Could you please add @define('SIZE_SHORT', 'Size'); and @define('SIZE_SHORT', 'Größe'); for consistency to lang files in master and 2.0, please.
add (image) file size short lang constant
add (image) file size short lang constant
Regards,
Ian
Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
Ian
Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
-
- Core Developer
- Posts: 30022
- Joined: Tue Sep 16, 2003 9:45 pm
- Location: Cologne, Germany
- Contact:
Re: add (image) file size short lang constant
What about IMAGE_SIZE and SORT_ORDER_SIZE? Ideally I'd like to use those instead of create new ones that do not exist in most translations already.Timbalu wrote:@Garvin
Could you please add @define('SIZE_SHORT', 'Size'); and @define('SIZE_SHORT', 'Größe'); for consistency to lang files in master and 2.0, please.
Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Re: add (image) file size short lang constant
Erm. We are going to need quite a few new lang constants for the new backend anyway. There's no way I am going to be able to implement the new backend the way it's supposed to be with the existing lang constants.garvinhicking wrote:What about IMAGE_SIZE and SORT_ORDER_SIZE? Ideally I'd like to use those instead of create new ones that do not exist in most translations already.
YL
Re: add (image) file size short lang constant
SORT_ORDER_SIZE (as media files can be more than images) would be fine with me... but, it is just the place where ORIGINAL_SHORT and THUMBNAIL_SHORT are used as siblings. That is why I thought a short "Size" would help to stay more consistency in look and feel (and might help in mobile views).garvinhicking wrote:Timbalu wrote:What about IMAGE_SIZE and SORT_ORDER_SIZE? Ideally I'd like to use those instead of create new ones that do not exist in most translations already.
Regards,
Ian
Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
Ian
Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
-
- Core Developer
- Posts: 30022
- Joined: Tue Sep 16, 2003 9:45 pm
- Location: Cologne, Germany
- Contact:
Re: add (image) file size short lang constant
Hi!
YL: Well, words that exist in our current translations should be re-used.
I am only arguing for this specific instance where I feel an existing translation owuld be better. That could differ in new scenarios where the new media backend needs specific sentences with changes; there we can only add new strings of course.
The "addlang.sh" script is a very simple shell script to add new constants to every language file; it is written for Linux/OSX in mind (because it uses iconv), but it should be possible to use windows iconv.exe similarities within a Batch-file...
Best regards,
Garvin
YL: Well, words that exist in our current translations should be re-used.
I am only arguing for this specific instance where I feel an existing translation owuld be better. That could differ in new scenarios where the new media backend needs specific sentences with changes; there we can only add new strings of course.
The "addlang.sh" script is a very simple shell script to add new constants to every language file; it is written for Linux/OSX in mind (because it uses iconv), but it should be possible to use windows iconv.exe similarities within a Batch-file...
Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/