Serendipity Forums

I have created an updated version of the SyntaxHighlighter module using version 2.1 from http://alexgorbatchev.com/wiki/SyntaxHighlighter
Can anyone grant me write access on CVS so I can commit?
I suppose this will make its way automatically into spartacus?
JM

(SF username is also jmroth)

Hi!

Could you post your patch here? Then I can quickly review and commit it. We usually give out CVS write access only after a few contributed patches...

Thanks a lot for your work and want to contribute!

Best regards,
Garvin

Here you go.
Here's the list of changes (can also be found in ChangeLog)

• updated to new upstream code
• legacy support is included (http://alexgorbatchev.com/wiki/SyntaxHi ... :Upgrading)
• version has become a variable in order to easily upgrade on upstream upgrade (just add new directory to /sh/ directory and change the variable)
• theme and scripts directory dynamically read to retrieve all brushes and themes
• theme can be selected in admin interface
• s9y plugin authors mentioned in help window

cs and cz files will need to be translated though (title and description!)

It's live on http://jeronimo.servehttp.com/ BTW.

JM

Hi!

Great, thanks a lot! I will work on this as soon as I have the time, I currently have an important project, so it might take me until Wednesday...

Regards,
Garvin

Sure. I am in no hurry

Hi!

I just committed it - it's a nice idea to add the bundled libraries there. One downside is that CVS cannot remove empty directories, so we will get empty directories for ever version upgrade. Depending on how often this happens, maybe only keep a "recent" named version directory might be better. It'S quite painful to remove so many files from CVS...

Thanks a lot for your contribution!

Best regards,
Garvin

Hey jmroth,

Thanks for getting around to this. I will completely admit that I have been very lazy in updating the plugin. I sort of took the "if it's not broken, don't fix it" approach, and wasn't sure how people would feel about the different look and feel of the updated 2.0 branch. Now that someone else did it, I don't have to worry about it!

I found one prob here:

On a shared install:

- the admin interface doesn't list the themes
- the blog complains that it can't find the brushes

Putting a "plugins" symlink from the shared install dir to the main plugins directory seems to fix the issue.

Is there something special to consider so that plugins are compatible to a site that's a shared install?
Or is the generation of the plugins symlink just missing from s9y.org/41.htm?
What else could be wrong?

Hi!

Sorry for that missing info, I changed it on the 41.html page. In fact, most plugins will run fine, but there is a percentage of plugins that refers to external JS/CSS files, which need to be callable through HTTP. So yeah, for plugins like the syntaxhighlighter, you'd need a symlink

Regards,
Garvin