Serendipity Forums

I have had my blog up for several years... Yesterday, I finally got up the nerve to upgrade. The upgrade went fairly smooth, However, now, I am missing the name and email, and the button to submit in the comments section. I don't know where to fix this... Can anyone help?

My blog is at http://scrapwarrior.com/blog/

Thanks,
Kris

Hi!

That seems odd, I believe there are language constant strings missing. Did you modify your custom template? Check the commentform.tpl file, maybe it is corrupted?

If you switch to a different template (temporarily) does it work then? If it doesn'T there as well, the main language file of yours might be corrupted through the upload!

Regards,
Garvin

Garvin, this corruption problem seems to happen regularly enough that we should consider doing something about it, if it's not too difficult.

Perhaps we could make a listing of files and their sha1 checksums, and check it during an upgrade? That way we can at least notify the user that their upload was corrupted.

Hi!

The problem is often FTP servers change ASCI encoding (\n to \r or \r\n) which changes the checksum, but not the validity of the files itself.

I agree that bad FTP uploading is a problem, but I'm not really sure on how to check that well enough...

Regards,
Garvin

I changed it over to another template.... and the comments are working fine...

Looks like I need to "re-customize" this new template with my header now...

THANKS!!!

Glad it worked for you!

Garvin, since ASCII mode only changes CR/LF and EOF, perhaps we could run a filter before hashing. This would take more time, but would warn the user when an error had occurred.

I had thought SHA1 ignored ASCII variations. I'm going to see if one of the other checksums does, instead.