Hi!
Committed! I performed a few modifications though to the default value of the path as well as using serendipity_db_bool where needed. If you could test that my changes didn'T break anything, that would be good.
Regards,
Garvin
Live comment preview
-
- Core Developer
- Posts: 30022
- Joined: Tue Sep 16, 2003 9:45 pm
- Location: Cologne, Germany
- Contact:
Re: Live comment preview
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
-
- Regular
- Posts: 1531
- Joined: Tue Mar 07, 2006 11:25 pm
- Location: Berlin, Germany
- Contact:
Re: Live comment preview
Does anybody think of the jquery-changes?onli wrote:Think the new version of livecomment created in the performance-related thread should find it's way to Spartacus.
sincerely
Ciao, Stephan
Re: Live comment preview
I didn't mention it here because I first wanted to wait a little longer to see if everything works. But I'll open a thread for it.
Garvin, the livecomment-plugin works fine also with your modifications.
Garvin, the livecomment-plugin works fine also with your modifications.
Re: Live comment preview
I just committed a small update to spartacus. $ got replaced with jQuery in the reallivecomment-script and noConflict was called to prevent issues when using other javascript-frameworks (or other jquery-Script which call that, like commentedit). Also, when not on an entry-page, the Javascript will not be linked.
- Attachments
-
- serendipity_event_livecomment-2.5.4.tar.gz
- (58.06 KiB) Downloaded 221 times