Posted: Tue Jun 17, 2008 8:11 pm
Well.
This was an adventure.
Turns out that the entries.tpl gets called before the frontend_header hook. Who knew? (It's probably in Garvin's book. If not, I've got an idea for an appendix...) Anyway, that led to a complaint about the {microformats_show} custom tag not existing, since it was being used before the frontend_header hook got a chance to define it.
I switched to plan B, but it was just as bad. Turns out that we don't pass $addData by reference, so the hooks can use it, but not modify it. My previous fix had no effect.
So I put everything back the way it was. I made one minor update: when it calls serendipity_smarty_init(), it passes the $addData so $view gets defined (or else it gets the hose again). THEN it goes on to assign all the variables it needs.
I also assigned the tabber.css directly in the header, although I don't see where it ever gets used outside the backend. Still, one less thing for the user to install (README updated).
This was more thoroughly tested, including a brief review on my sandbox to verify that everything would work. It did. Committed. Should be available in 24 hours.
Oh. I only updated the English language files. I'm just too frustrated to go any farther.
This was an adventure.
Turns out that the entries.tpl gets called before the frontend_header hook. Who knew? (It's probably in Garvin's book. If not, I've got an idea for an appendix...) Anyway, that led to a complaint about the {microformats_show} custom tag not existing, since it was being used before the frontend_header hook got a chance to define it.
I switched to plan B, but it was just as bad. Turns out that we don't pass $addData by reference, so the hooks can use it, but not modify it. My previous fix had no effect.
So I put everything back the way it was. I made one minor update: when it calls serendipity_smarty_init(), it passes the $addData so $view gets defined (or else it gets the hose again). THEN it goes on to assign all the variables it needs.
I also assigned the tabber.css directly in the header, although I don't see where it ever gets used outside the backend. Still, one less thing for the user to install (README updated).
This was more thoroughly tested, including a brief review on my sandbox to verify that everything would work. It did. Committed. Should be available in 24 hours.
Oh. I only updated the English language files. I'm just too frustrated to go any farther.