Markup-Buttons for comments

Creating and modifying plugins.
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Markup-Buttons for comments

Post by garvinhicking »

Hi!

the "install()" method is called immediately when the plugin is initialized (not an event hook).

HTH.
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
onli
Regular
Posts: 2836
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Markup-Buttons for comments

Post by onli »

Thanks Garvin, it helped. Seems to work perfect. For the record: misusing introspect_config_item works, too, if done properly - but install() is better.

Also included new jquery-release.
sincerely
Attachments
serendipity_event_jquery-1.3.2.tar.gz
(21.03 KiB) Downloaded 210 times
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Markup-Buttons for comments

Post by garvinhicking »

Hi!

Thanks, committed!

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
abdussamad
Regular
Posts: 117
Joined: Fri Apr 21, 2006 10:11 pm
Location: Karachi, Pakistan
Contact:

Re: Markup-Buttons for comments

Post by abdussamad »

I just installed this plugin on my blog and its not working. A look at the firefox error console tells me that "jquery is not defined". The plugin is not including the bundled jquery.js like its supposed to. Since I am already using the html in head plugin I just added a line to include jquery.js using that. Please make the plugin emit:

<script type="text/javascript" src="/plugins/serendipity_event_livecomment/jquery.js"></script>

Apart from that its a nice plugin! Thanks for making it onli!
onli
Regular
Posts: 2836
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Markup-Buttons for comments

Post by onli »

Hi abdussamad
Thanks for the feedback. The plugin should no longer iclude jQuery by itself, but install the jQuery-Plugin from Spartacus.
sincerely
konus
Regular
Posts: 334
Joined: Mon Jun 16, 2008 1:57 pm
Location: Dresden, Germany
Contact:

Re: Markup-Buttons for comments

Post by konus »

onli wrote:Hi abdussamad
Thanks for the feedback. The plugin should no longer iclude jQuery by itself, but install the jQuery-Plugin from Spartacus.
sincerely
I just wanted to point out, that I had to install jQuery manually to enable the plugin.
onli
Regular
Posts: 2836
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Markup-Buttons for comments

Post by onli »

When installing the livecomment-plugin?
Ah, wrong thread - of course when installing the livecomment-plugin. Garvin, can you have a look at this? We have reports about that from the beginning from different people. Is the dependency declared wrong or is there a bug in the dependency-system?
Post Reply