Don't flip around comments

Found a bug? Tell us!!
Post Reply
hanno
Regular
Posts: 72
Joined: Fri May 20, 2005 8:04 am
Contact:

Don't flip around comments

Post by hanno »

Hi,

S9Y has a behaviour in the comments that imho makes it less usable: When activating/marking a comment (in the admin backend), it's border flips from 1px to 2px.

Especially if you "invert selection" on a large number of comments, your buttons may flip out of the visible area.

So my suggestion is to just leave this "feature" away. Patch see below.

--- include/admin/comments.inc.php.1 2008-06-24 16:41:13.000000000 +0200
+++ include/admin/comments.inc.php 2008-06-24 16:41:21.000000000 +0200
@@ -283,10 +283,8 @@
var comment = document.getElementById(id);
if (checkvalue) {
comment.style.borderColor = '#FF0000';
- comment.style.borderWidth = 2;
} else {
comment.style.borderColor = '';
- comment.style.borderWidth = '';
}
}
</script>
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Don't flip around comments

Post by garvinhicking »

Hi!

I've disabled it from flipping to 2px, and leave it at 1px.

Thanks for your input, and sorry it got delayed! :(

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply