Bug with Geomap

Found a bug? Tell us!!
Post Reply
julduck
Posts: 3
Joined: Mon Nov 26, 2007 3:26 pm

Bug with Geomap

Post by julduck »

Hi all,

I just downloaded the Geomap plugin from Spartacus and I get a showstopper.

As soon as I activate the Geomap event plugin, I cannot edit or create a new entry. The web site says "Operation failed".

My website is http://www.cvbs.fr/ and my admin is set in French (don't know if that has an influence).

Can anybody help me out?
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Bug with Geomap

Post by garvinhicking »

Hi!

How does this "operation failed" look like? Can you make a screenshot?

Are you sure you entered your Google Maps API key correctly?

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
julduck
Posts: 3
Joined: Mon Nov 26, 2007 3:26 pm

Post by julduck »

Hi garvinhicking,

Thanks for quick reply.

Just to make sure, I just did an update. I now use serendipity 1.2 and Geotag version: 1.19. I also use IE 7.0.5730.11

I did reconfigure the plugin and made sure the key was copied / pasted with great care.

I did upload a screenshot of the error here:
http://www.cvbs.fr/images/error.bmp

Sorry, it's in French, but I guess you can understand its meaning ;o)

Thanks for your help.
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

Could you try to use Firefox and test it? The IE error is very hard to interpret what's going on. Firefox usually better shows what is wrong...

REgards,
Garvin
julduck wrote:Hi garvinhicking,

Thanks for quick reply.

Just to make sure, I just did an update. I now use serendipity 1.2 and Geotag version: 1.19. I also use IE 7.0.5730.11

I did reconfigure the plugin and made sure the key was copied / pasted with great care.

I did upload a screenshot of the error here:
http://www.cvbs.fr/images/error.bmp

Sorry, it's in French, but I guess you can understand its meaning ;o)

Thanks for your help.
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
julduck
Posts: 3
Joined: Mon Nov 26, 2007 3:26 pm

Post by julduck »

It does work OK in Firefox. There must be something incompatible in the javascript to pick a location.

However, I did maintain my locations with Firefox and the map on the sidebar did not show anything relevant.

I'll just give up with Geotagging my entries and I'll keep doing that in Picasa.

Did anybody ever succeed in making this script work?

Julien
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

In my tests this worked, yes.

You must wait a day, until Google picks up your RSS geotagged feed to display your geotagged locations!

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
VladaAjgl
Regular
Posts: 44
Joined: Mon Nov 19, 2007 10:00 pm
Contact:

Bug in Geotag plugin

Post by VladaAjgl »

Hi,
I am a bit surprized that there is nobody who reports that geotag does not work. Becuase my one does not. I took a sight into the code... And it is because in the serendipity_geotag_plugin.php file on line 141 (and it is in the current version in CVS repository) is a bad constant name in javascript, which should be

map.setMapType(G_HYBRID_TYPE);
( instead of map.setMapType(_HYBRID_TYPE) )

and this is the place where javascript stops...

Then I was surprized the way the plugin gets the location data. It reads your own RSS feed using javascript http request (Garvin, you are wrong, google maps has nothing in common with this rss), then it parses its xml structure, in javascript, which needs to solve troubles with compatibility between different browsers... wouldn't it be more simple to get the data directly from database? ... It would save the network communication, it would save the time, it would save the code size.

So this is a peckish remark for plugin authors (or future rewriters). And for future... maybe it would be nice to add a settings of center point of the map.

Regards
Vladimir
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Bug in Geotag plugin

Post by garvinhicking »

Hi!

Good catch, I fixed that constant bug. I believe the RSS reading feature was an example of google maps application layer, that's why it was used instead of fetching from the DB.

The RSS code has the benefit, that the plugin does not need to execute the whole DB fetching routine on the same page again, but on a seperate HTTP request. That makes the load balancing on the webserver a little easier and puts caching possibilites (HTTP Conditional get) into the RSS feed fetching.

It might be nice to have the option of straight fetching frm the DB, though! :)

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
VladaAjgl
Regular
Posts: 44
Joined: Mon Nov 19, 2007 10:00 pm
Contact:

Re: Bug in Geotag plugin

Post by VladaAjgl »

garvinhicking wrote: It might be nice to have the option of straight fetching frm the DB, though! :)
Hi,
do you do the things in a way "say something and do it yourself" ? I do. Often:-) I couldn't withstand the parsing of geotags from rss feed and I modified the geotag plugin to have a posibility to read the data directly from the database. And some other small fixes.
Here you are:
http://vlada.ajgl.cz/myplugins/serendip ... geotag.zip
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Bug in Geotag plugin

Post by garvinhicking »

Hi!

Hehe, thanks a lot!
do you do the things in a way "say something and do it yourself" ? I do. Often:-)
I often did in the past, but am finding less and less time to actually implement things. But that'll become better again, once I finish that Serendipity book. :)

Committed your patch, thanks a lot!

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply