If they are needed by all colorsets, they should - if it's only to save some space Please remind me to not forget this particular fix once I start merging those CSS elements to either one of the above stylesheets.Don Chambers wrote:One other thing regarding those colorsets I sent out. Need the following:Without that, the navbar wipes out part of the banner when the navbar is located above the banner. Did not notice that until this morning.Code: Select all
#serendipity_banner {clear: both}
I am also wondering if this addition, plus a few of the other lines of code in the colorset.css files should be in style.css and/or base.css.
Okay, so I have done at least some testing under Windows - I think we have too many features now to carefully test any possible configuration in any browser without going nuts As far as I can see, Don's latest bugfixing frenzy seems pretty successful, at least I didn't see anything bad besides the following:
a) most of the colorsets have one or more issues in IE < 6 - personally, I say "Screw IE < 6"; so these issues are - in my humble opinion - neglectable
b) I have only tested this with the navbar above the header, but in that case hovering a link "makes the navbar bigger". Unfortunately, this happens in all modern browsers (and in the green and blue colorset, for that matter), so we're gonna have to fix that one.
Despite that, I'm fine with Don's fixes, but I'd rather wait for a decision by Dave on this since he knows the colorset stylesheet much better than I do.
Anyway, great job Don! I think we're gonna have to call you the "Yoda of bughunting" from now on Seriously, way to go.
YL