RBL plugin check

Creating and modifying plugins.
Post Reply
Noelb
Regular
Posts: 120
Joined: Wed Jul 27, 2011 7:16 am

RBL plugin check

Post by Noelb »

Hey all, just wondering if anyone is using this plugin can verify it still working in 2.5.0 w/php8.2.29? (serendipity_event_spamblock_rbl)

I'm using "bl.zonecheck.org,sbl-xbl.spamhaus.org"

I know this one sods IP is listed in the first one but they got 7 messages in overnight.

Code: Select all

 host -t txt XXX.XXX.154.78.bl.zonecheck.org
XXX.XXX.154.78.bl.zonecheck.org descriptive text "Junk - see htt
(the listed date is 3 weeks ago so not new)

I don't know why I'm protecting this fxxx IP, but in case its dynamcic assignment I dont want to shame any current user who ay or may not be innocent :)

I assume the separator hasn't changed from comma?
Doesn't appear to be checking, also is the ordering of this plugin important? I don't recall it being so in the past.

Given the big changes with php from 7 .4 to 8.2 i'm not past blaming php again :) That's why I thought I'd ask..

Cheers
onli
Regular
Posts: 3022
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: RBL plugin check

Post by onli »

We have an issue open for these plugins, https://github.com/s9y/Serendipity/issues/500. I think the Net_DNSBL dependency was updated in the meantime, but I'd have to check later. In any case, those plugins need a maintainer. They are used a bit less often than the other spamblock plugins I think and I'm not sure about their state.

Plugin order changes when they are run, can matter for spamblock plugins.
Noelb
Regular
Posts: 120
Joined: Wed Jul 27, 2011 7:16 am

Re: RBL plugin check

Post by Noelb »

Hi onli,
oh wow 5 years, yeah its DOA for sure, I use a rbl.php file for normal on my sites contact pages, do we really need Net DNSBL etc?
I'll try attach it, its very plain.
rbl-php.txt
rbl.php file
(1.88 KiB) Downloaded 485 times
Noelb
Regular
Posts: 120
Joined: Wed Jul 27, 2011 7:16 am

Re: RBL plugin check

Post by Noelb »

Just posting this for anyone else getting onslaught of vermin abusing the system, using v 2.5.0.
Grab the above mentioned rbl-php file, rename it rbl.php stick it in serendipity's root directory, then.... (backup these 2 files before editing!!!!)

-POST SUBMISSIONS-

Add in include/functions_routing.inc.php
include(S9Y_INCLUDE_PATH . 'rbl.php');
at line 350 immediately before the line:
if (!empty($serendipity['POST']['submit']) && !isset($_REQUEST['serendipity']['csuccess'])) {

next, if you use the contactform plugin
-CONTACTFORM-

Add in plugins/serendipity_event_contactform/serendipity_event_contactform.php
include(S9Y_INCLUDE_PATH . 'rbl.php');

at line 210 immediately before the line:
return serendipity_sendMail($to, $subject, $text, $fromEmail, null, $fromName);



Like that crazy Belgian dude who sang that nonsical hit in French back in late 70's said...

ca plane pour moi.... this works for me :)
onli
Regular
Posts: 3022
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: RBL plugin check

Post by onli »

Noelb, your implementation is great. I'm not keen on maintaining that plugin, but I'm willing to upgrade it if it means we can get rid of the DNSBL dependency in the core. So I took your code, simplified it and created a PR for the spamblock_rbl plugin: https://github.com/s9y/additional_plugins/pull/206. For me that code works.

(Though I should note, that on my install the old code also worked - the rbl plugin was not broken for me, on PHP 8.4. Maybe something specific of different blacklists. The new code worked with the old settings, so it seems to cover all cases.)

Maybe you could test it as well? Deactivate your custom integration for a bit and give the new plugin version from the PR a test run?
Noelb
Regular
Posts: 120
Joined: Wed Jul 27, 2011 7:16 am

Re: RBL plugin check

Post by Noelb »

Hi onli,
Thanks, will try find time to give it a shot in next few days, rather busy at moment, big project to finish.
Cheers
onli
Regular
Posts: 3022
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: RBL plugin check

Post by onli »

I merged it already :) Given that the old version was reported as flaky and that the new one worked for me equally. A test would still be great, but now easier - version 1.6 should be available via Spartacus tomorrow.
Noelb
Regular
Posts: 120
Joined: Wed Jul 27, 2011 7:16 am

Re: RBL plugin check

Post by Noelb »

onli wrote: Thu Oct 30, 2025 10:10 am I merged it already :) Given that the old version was reported as flaky and that the new one worked for me equally. A test would still be great, but now easier - version 1.6 should be available via Spartacus tomorrow.
Hi, sorry for the long delay. This isn't available anymore? When using update plugins, reports nothing to do?
onli
Regular
Posts: 3022
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: RBL plugin check

Post by onli »

I see serendipity_event_spamblock_rbl 1.6 in spartacus and also do get it offered in my dev blog to install. What version is installed currently in the blog? Is spartacus configured to get packages from github?
Noelb
Regular
Posts: 120
Joined: Wed Jul 27, 2011 7:16 am

Re: RBL plugin check

Post by Noelb »

onli wrote: Tue Dec 02, 2025 6:18 pm I see serendipity_event_spamblock_rbl 1.6 in spartacus and also do get it offered in my dev blog to install. What version is installed currently in the blog? Is spartacus configured to get packages from github?
I've only ever gone into plugins and used check for updates, event plugin spartacus is installed and already set to use github, is there another place I should be looking to run this instead of normal update check?

Edited... Version is 1.5.2 installed
onli
Regular
Posts: 3022
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: RBL plugin check

Post by onli »

No, that sounds correct. Set github in Spartacus' settings and go to plugin updates in the plugin backend menu. Maybe try with Gitlab instead, maybe Github is blocked on your server now? That's my one idea for the moment. If nothing helps I will try to reproduce on my dev setup.
Noelb
Regular
Posts: 120
Joined: Wed Jul 27, 2011 7:16 am

Re: RBL plugin check

Post by Noelb »

onli wrote: Thu Dec 04, 2025 2:54 pm No, that sounds correct. Set github in Spartacus' settings and go to plugin updates in the plugin backend menu. Maybe try with Gitlab instead, maybe Github is blocked on your server now? That's my one idea for the moment. If nothing helps I will try to reproduce on my dev setup.
Shouldnt be any blockings, gitlab results in same, no plugin updates are available
spartacus v 2.39.2 if that matters.

The systems working fine so absolutely no urgency, just trying to try this plugin update to keep things clean, as I'm sure you agree it's much better and smarter to use official code that does the same thing now, than using custom edits :)

The last timestamp on /plugins (excluding the couple pugins with these custom changes) was
(AEST) Jul 6 00:03 serendipity_event_social/ if that helps - there may be other plugin updates for stable 2.5.0 I'm not seeing too? I think I saw 66 plugins reports somewhere (I sure as hell don't have THAT many loaded LOL)
onli
Regular
Posts: 3022
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: RBL plugin check

Post by onli »

Seems like spartacus is broken in your blog since a bit. The social plugin has seen its last update in October of this year, https://github.com/s9y/additional_plugins/pull/204. Its current version is 1.2.

Check against these settings:
Screenshot 2025-12-08 at 12-12-55 Plugins John Doe's personal blog Serendipity Administration Suite.png
Screenshot 2025-12-08 at 12-12-55 Plugins John Doe's personal blog Serendipity Administration Suite.png (166.33 KiB) Viewed 2851 times
With them spartacus works for upgrading the rbl plugin:
Screenshot 2025-12-08 at 12-11-50 Plugins John Doe's personal blog Serendipity Administration Suite.png
Screenshot 2025-12-08 at 12-11-50 Plugins John Doe's personal blog Serendipity Administration Suite.png (60.29 KiB) Viewed 2851 times
I'm not aware of a fix in spartacus that would explain the difference (the dev blog the screenshots are from runs the current git master), but if the settings are correct maybe there is something in the php error log when you try to update plugin? The dev blog uses 2.39.3 of spartacus, which is just this difference: https://github.com/s9y/Serendipity/comm ... bc278702ba - I doubt it, but try whether changing

Code: Select all

$upgradeVersion = null;
to

Code: Select all

$upgradeVersion = '';
in line 1179 helps?
Noelb
Regular
Posts: 120
Joined: Wed Jul 27, 2011 7:16 am

Re: RBL plugin check

Post by Noelb »

my settings match option for option, are you sure what you're showing is for 2.5.0? It's not for dev branch is it? which might explain the discrepancies.
onli
Regular
Posts: 3022
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: RBL plugin check

Post by onli »

Spartacus and those settings should work regardless. But sure, you can try the version that is in the github master, of serendipity or just of the spartacus plugin.
Post Reply