RBL plugin check

Creating and modifying plugins.
Post Reply
Noelb
Regular
Posts: 116
Joined: Wed Jul 27, 2011 7:16 am

RBL plugin check

Post by Noelb »

Hey all, just wondering if anyone is using this plugin can verify it still working in 2.5.0 w/php8.2.29? (serendipity_event_spamblock_rbl)

I'm using "bl.zonecheck.org,sbl-xbl.spamhaus.org"

I know this one sods IP is listed in the first one but they got 7 messages in overnight.

Code: Select all

 host -t txt XXX.XXX.154.78.bl.zonecheck.org
XXX.XXX.154.78.bl.zonecheck.org descriptive text "Junk - see htt
(the listed date is 3 weeks ago so not new)

I don't know why I'm protecting this fxxx IP, but in case its dynamcic assignment I dont want to shame any current user who ay or may not be innocent :)

I assume the separator hasn't changed from comma?
Doesn't appear to be checking, also is the ordering of this plugin important? I don't recall it being so in the past.

Given the big changes with php from 7 .4 to 8.2 i'm not past blaming php again :) That's why I thought I'd ask..

Cheers
onli
Regular
Posts: 3002
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: RBL plugin check

Post by onli »

We have an issue open for these plugins, https://github.com/s9y/Serendipity/issues/500. I think the Net_DNSBL dependency was updated in the meantime, but I'd have to check later. In any case, those plugins need a maintainer. They are used a bit less often than the other spamblock plugins I think and I'm not sure about their state.

Plugin order changes when they are run, can matter for spamblock plugins.
Noelb
Regular
Posts: 116
Joined: Wed Jul 27, 2011 7:16 am

Re: RBL plugin check

Post by Noelb »

Hi onli,
oh wow 5 years, yeah its DOA for sure, I use a rbl.php file for normal on my sites contact pages, do we really need Net DNSBL etc?
I'll try attach it, its very plain.
rbl-php.txt
rbl.php file
(1.88 KiB) Downloaded 213 times
Noelb
Regular
Posts: 116
Joined: Wed Jul 27, 2011 7:16 am

Re: RBL plugin check

Post by Noelb »

Just posting this for anyone else getting onslaught of vermin abusing the system, using v 2.5.0.
Grab the above mentioned rbl-php file, rename it rbl.php stick it in serendipity's root directory, then.... (backup these 2 files before editing!!!!)

-POST SUBMISSIONS-

Add in include/functions_routing.inc.php
include(S9Y_INCLUDE_PATH . 'rbl.php');
at line 350 immediately before the line:
if (!empty($serendipity['POST']['submit']) && !isset($_REQUEST['serendipity']['csuccess'])) {

next, if you use the contactform plugin
-CONTACTFORM-

Add in plugins/serendipity_event_contactform/serendipity_event_contactform.php
include(S9Y_INCLUDE_PATH . 'rbl.php');

at line 210 immediately before the line:
return serendipity_sendMail($to, $subject, $text, $fromEmail, null, $fromName);



Like that crazy Belgian dude who sang that nonsical hit in French back in late 70's said...

ca plane pour moi.... this works for me :)
onli
Regular
Posts: 3002
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: RBL plugin check

Post by onli »

Noelb, your implementation is great. I'm not keen on maintaining that plugin, but I'm willing to upgrade it if it means we can get rid of the DNSBL dependency in the core. So I took your code, simplified it and created a PR for the spamblock_rbl plugin: https://github.com/s9y/additional_plugins/pull/206. For me that code works.

(Though I should note, that on my install the old code also worked - the rbl plugin was not broken for me, on PHP 8.4. Maybe something specific of different blacklists. The new code worked with the old settings, so it seems to cover all cases.)

Maybe you could test it as well? Deactivate your custom integration for a bit and give the new plugin version from the PR a test run?
Noelb
Regular
Posts: 116
Joined: Wed Jul 27, 2011 7:16 am

Re: RBL plugin check

Post by Noelb »

Hi onli,
Thanks, will try find time to give it a shot in next few days, rather busy at moment, big project to finish.
Cheers
onli
Regular
Posts: 3002
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: RBL plugin check

Post by onli »

I merged it already :) Given that the old version was reported as flaky and that the new one worked for me equally. A test would still be great, but now easier - version 1.6 should be available via Spartacus tomorrow.
Post Reply