[freetag] constantly generates PHP warning in the log

[wesley]

While troubleshooting for a fatal error caused by SPARTACUS (for some reason, the php file was slightly corrupted), I noticed another string of errors stemming from the freetag plugin in the Apache server log:

Code: Select all

PHP Warning: explode() expects parameter 2 to be string, array given in (path)/serendipity_event_freetag.php on line 1037, referer: (site)/plugin/tag/(tag name)/

This seems to be generated quite often, but not always when a page is loaded.
Looking at the code, it seems to be related to the line that goes like this:

Code: Select all

if (!empty($this->tags['show'])) {
    if (is_array($this->tags['show'])) {
        $showtag = array_map('serendipity_db_escape_string', $this->tags['show']);
    } else {
        $showtag = serendipity_db_escape_string($this->tags['show']);
    }
} else if (!empty($serendipity['GET']['tag'])) {
    $showtag = serendipity_db_escape_string(urldecode($serendipity['GET']['tag']));
}
$arr_showtag = explode(';', $showtag);

The code may pass array_map() to $showtag, but explode() doesn't seems to like this. I wonder why it's coded this way, and would there be a way to avoid generating the errors in the log?

[garvinhicking]

Hi!

Hm I believe this is an actual flaw in the logic; if the array_map is used, explode isn't used.

I would suggest rewriting it to:

Code: Select all

if (!empty($this->tags['show'])) {
    if (is_array($this->tags['show'])) {
        $showtag = array_map('serendipity_db_escape_string', $this->tags['show']);
    } else {
        $showtag = serendipity_db_escape_string($this->tags['show']);
    }
} else if (!empty($serendipity['GET']['tag'])) {
    $showtag = serendipity_db_escape_string(urldecode($serendipity['GET']['tag']));
}

if (is_array($showtag)) {
    $arr_showtag = $showtag;
} else {
    $arr_showtag = explode(';', $showtag);
}

Can you test this? If it works, I'd commit it to the plugin repo...

Thanks,
Garvin

[wesley]

The revised code seems to work. The error hasn't been showing up since.

[garvinhicking]

Cool, thanks! Committed!

[Lux]

Can you test this? If it works, I'd commit it to the plugin repo...

With 2.0 beta I do not see a clickable list of tags below my article any more.

Can you please check?

BTW:

Cheers

Dirk

[yellowled]

With 2.0 beta I do not see a clickable list of tags below my article any more.

Might be http://board.s9y.org/viewtopic.php?p=10440023 (German).

YL

[Lux]

With 2.0 beta I do not see a clickable list of tags below my article any more.

Might be http://board.s9y.org/viewtopic.php?p=10440023 (German).

Looks like, I will answer there.

Cheers

Dirk