Wrong code in Download-Packages

Having trouble installing serendipity?
Post Reply
MarioH
Regular
Posts: 238
Joined: Mon Jul 20, 2009 10:53 pm
Contact:

Wrong code in Download-Packages

Post by MarioH »

Hi all,

i'm not sure, but i downloaded the beta packages for 2.0 beta 1 and i got errors after copying the files over my test installation. There was no update dialog after loading the test site.

Then I examinated the serendipity_config.inc.php an saw this:

// The version string
$serendipity['version'] = '1.7-alpha1';

Greets
Mario
MarioH
Regular
Posts: 238
Joined: Mon Jul 20, 2009 10:53 pm
Contact:

Re: Wrong code in Download-Packages

Post by MarioH »

I downloaded the beta-2 from github and everything is ok.
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: Wrong code in Download-Packages

Post by Timbalu »

There is nothing wrong with the 2.0-beta-1 zip announced here in download section as far as I can see.
I would assume it was some kind of upload (ftp) error which hit you.
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
MarioH
Regular
Posts: 238
Joined: Mon Jul 20, 2009 10:53 pm
Contact:

Re: Wrong code in Download-Packages

Post by MarioH »

Hi,

no, Garvin fixed the packages last night, they were accidently built against the master-branch.

Greets
Mario
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: Wrong code in Download-Packages

Post by Timbalu »

Oh, well then ... :mrgreen: (which does not explain why it held a v.1.7-alpha1)
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: Wrong code in Download-Packages

Post by yellowled »

Timbalu wrote:(which does not explain why it held a v.1.7-alpha1)
Garvin mentioned something on Twitter about the release script accidentally pulling the master instead on the 2.0 branch.

YL
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Wrong code in Download-Packages

Post by garvinhicking »

Hi!

Reason was that I used this buildscript:

Code: Select all

#!/bin/bash

cd git/2.0/Serendipity
git pull
git archive --output release.tar --prefix serendipity/ master
mv release.tar ../../../
cd ../../../
rm -rf serendipity
tar -xvf release.tar
rm serendipity-2.0-beta1.tar.gz
rm serendipity-2.0-beta1.zip
cd serendipity/bundled-libs
./create_release.sh serendipity-2.0-beta1.tar.gz serendipity nobody nogroup
cd ../../
zip -9 -r serendipity-2.0-beta1.zip serendipity
tar --owner=nobody --group=nogroup -cjf "serendipity-2.0-beta1.tar.bz2" serendipity
cd serendipity
mkdir templates_stripped
mv templates/default templates_stripped/
mv templates/carl_contest templates_stripped/
mv templates/bulletproof templates_stripped/
mv templates/2k11 templates_stripped/
rm -rf templates
mv templates_stripped templates
rm -rf deployment
rm checksums.inc.php
cd ..
zip -r serendipity-2.0-beta1-lite.zip serendipity
tar --owner=nobody --group=nogroup -czf "serendipity-2.0-beta1-lite.tar.gz" "serendipity"
tar --owner=nobody --group=nogroup -cjf "serendipity-2.0-beta1-lite.tar.bz2" "serendipity"

scp serendipity/docs/NEWS garvinhicking@frs.sourceforge.net:/home/frs/project/p/ph/php-blog/serendipity/2.0-beta1/README
scp serendipity-2.0-beta1* garvinhicking@frs.sourceforge.net:/home/frs/project/p/ph/php-blog/serendipity/2.0-beta1/
php s9ymd5.php 2.0-beta1
echo "Also update docs/RELEASE!"
However, this single line:

Code: Select all

git archive --output release.tar --prefix serendipity/ master
Supposedly only checked out the master branch of my "2.0" directory checkout, which I did ages ago (1.7 alpha).

I changed the line to read:

Code: Select all

git archive --output release.tar --prefix serendipity/ 2.0
and then reuploaded the release.

Sorry for this bug, I wasn't careful enough. :-(
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply