As you all know, I usually update the bundled jQuery to the latest release pretty quick. Turns out I'm not going to be able to do that for jQuery 1.9 …
jQuery 1.9 introduces some changes which seem potentially harmful given the fact that some jQuery code already used in s9y and its plugin could be rather old and much more likely to use features deprecated in jQuery 1.9.
Definitely not an option for the pending 1.7 release.
Thanks to jQuery migrate, it is pretty simple to test for 1.9 compatibility. I also suppose most JS in s9y and plugins is still native JS. Anyway, do we have a list of plugins which actually use jQuery?
YL
jQuery 1.9
-
- Core Developer
- Posts: 30022
- Joined: Tue Sep 16, 2003 9:45 pm
- Location: Cologne, Germany
- Contact:
Re: jQuery 1.9
Hi!
I think greping for $(...) and jQuery in all plugins should yield all occurences...?
I think greping for $(...) and jQuery in all plugins should yield all occurences...?
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Re: jQuery 1.9
Sure, I just thought it might be quicker if someone knew – “That's just A, B, and C.”
Hm, probably a good idea to grep templates as well, there might be some themes on Spartacus which use jQuery …
YL
Hm, probably a good idea to grep templates as well, there might be some themes on Spartacus which use jQuery …
YL
Re: jQuery 1.9
Stop! No, not in my eyes!yellowled wrote:Definitely not an option for the pending 1.7 release.
If that is the decision to not modernize any third party component, we would never get any further!!!
If you wait, it will get even more worse. So this is not an option, IMO. We have to care that it does not break anything in core, this is our main responsibility.
People who have made custom codings with one of those deprecated methods will get to know that, if we announce possible behaviour changes in the news. Its up to them to change their code, ask for help to migrate, bundle the old jquery file again or even stick with their old Serendipity version.
A quick run through additional plugins or themes is fine, but then go!
Regards,
Ian
Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
Ian
Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
Re: jQuery 1.9
Erm, it is a decision to not bundle jQ 1.9 with s9y 1.7, nothing more.Timbalu wrote:If that is the decision to not modernize any third party component, we would never get any further!!!
It will be tested for 1.8 or even 1.7.1, and I also assume there won't be that many issues. But I wouldn't want to stop Garvin from even creating the release candidate next weekend.
Do you have the time to properly test 1.7, plugins and themes on Spartacus for compatibility with jQ 1.9 until then? Be my guest. I don't even have the time to test 2k11 until then.
YL
Re: jQuery 1.9
So I just gave this a little test spin with jQuery 1.9.1 and the jQuery Migrate plugin, which basically is a small test suite for jQuery 1.9.x.yellowled wrote:It will be tested for 1.8 or even 1.7.1, and I also assume there won't be that many issues.
Turns out the s9y 1.7 backend is incompatible with jQuery 1.9.x because it doesn't have a proper doctype. Therefore, the backend is running in quirks mode, which jQuery 1.9.x does not support (see https://github.com/jquery/jquery-migrat ... arnings.md).
Best thing about this is that it's not even a big deal for us. As long as the 1.7 branch is our stable version, we'll stick to 1.8.3, which is in 1.7 and is the latest jQuery < 1.9.x. The 2.0 backend does have a proper doctype, so that shouldn't be an issue. Of course, this increases the testing we'll need to do with the 2.0 branch and plugins, but the number of plugins which already use jQuery is pretty small.
YL
Re: jQuery 1.9
Ah, now I see why it is working in my Dashboard PoC. I even switched to jQuery 2.0.0.
Regards,
Ian
Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
Ian
Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian