see if commenter is subscribed to answers

Random stuff about serendipity. Discussion, Questions, Paraphernalia.
Post Reply
konus
Regular
Posts: 334
Joined: Mon Jun 16, 2008 1:57 pm
Location: Dresden, Germany
Contact:

see if commenter is subscribed to answers

Post by konus »

Hello, sometimes I get a question in the comments. I normally answer the question in the comments. It would be good to know, whether the author of the comment enabled the subscription of comments (and successful completed opt-in), to decide if I have to send him an extra mail or not.

1. Would it be possible to show this information next to each comment on blog (to logged in admins only, like the mail address)?
2. It would also be nice to see the status (and maybe edit it) in the admin panel in the comments section. How about tree little Icons (not subscribed, confirmation pending, yes subscribed)
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: see if commenter is subscribed to answers

Post by garvinhicking »

Hi!

That's a good idea. This should be possible. But I'd rather solve this in the s9y core, so you won't be able to use the solution in a plugin...

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
konus
Regular
Posts: 334
Joined: Mon Jun 16, 2008 1:57 pm
Location: Dresden, Germany
Contact:

Re: see if commenter is subscribed to answers

Post by konus »

So how could I help? Do you need some Icons? Or would it be enough to change the background color of the email-link?
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: see if commenter is subscribed to answers

Post by garvinhicking »

Hi!

I think the color should be okay. I've put this on my todo list, but it might take some days or weeks for me to implement.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: see if commenter is subscribed to answers

Post by garvinhicking »

Hi!

Just committed a first draft to SVN trunk that enables showing if subscription is on in the frontend ("off" is IMHO useless information, "pending confirmation" is useless because unconfirmed comments are not displayed in the frontend).

Inside the backend, pending comments are already highlighted, so again I only show a "(Subscribed)" behind the email, if such a comment has subscription enabled.

HTH,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
konus
Regular
Posts: 334
Joined: Mon Jun 16, 2008 1:57 pm
Location: Dresden, Germany
Contact:

Re: see if commenter is subscribed to answers

Post by konus »

Great!
With "pending confirmation" I did not mean the confirmation of the comment itself but the confirmation, that a commenter really want to get subscribed by clicking on the link in the confirmation mail. But anyway, I think the two states are enough. Subscribed or not!

Unfortunately I don't have a test-blog. But I am looking forward.
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: see if commenter is subscribed to answers

Post by garvinhicking »

Hi!

I believe seperating the last out could be harder to achieve, because comment subscription is not computed upon the comment, but on a general token. If you confirm once for any entry on the blog, all entries of the blog are allowed to be subscribed to.

IMHO, having "subscribed=true" displayed in the frontend should suffice, because that is the only way where a comment frmo you would be returned to the user. So you don't really achieve any new information if you knew he had not yet confirmed his subscription?

The problem is, that querying the distinct token in the database would mean a completely new database lookup for every comment, and I wouldn't really like to do that. Also, I think adding an option for this would be a bit bloaty...?!

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
konus
Regular
Posts: 334
Joined: Mon Jun 16, 2008 1:57 pm
Location: Dresden, Germany
Contact:

Re: see if commenter is subscribed to answers

Post by konus »

I agree, lets keep it as simple as possible! It makes no sense in this case.
Post Reply