Page 1 of 1
Timeline - No Sharebuttons in article overwiew
Posted: Sat Jun 25, 2016 5:19 pm
by MarioH
Hi,
within the new plugin serendipity_event_social you can configure to show the sharebuttons in article overviews. in Timeline the buttons are not displayed even the option in the plugin is set.
Regards
Mario
Re: Timeline - No Sharebuttons in article overwiew
Posted: Sun Jun 26, 2016 11:48 am
by Lux
MarioH wrote:within the new plugin serendipity_event_social you can configure to show the sharebuttons in article overviews. in Timeline the buttons are not displayed even the option in the plugin is set.
Interesting that it works for me
Strange.
Dirk
Re: Timeline - No Sharebuttons in article overwiew
Posted: Sun Jun 26, 2016 12:25 pm
by MarioH
Hi,
Lux wrote:Interesting that it works for me
What do you mean? Do you have a blog with the Timeline-Theme and you have the buttons in the articel overview?
In other themes it works well, so I thought this has to be theme-related.
Regards
Mario
Re: Timeline - No Sharebuttons in article overwiew
Posted: Sun Jun 26, 2016 1:48 pm
by Lux
MarioH wrote:In other themes it works well, so I thought this has to be theme-related.
Yes, it seems so.
Cheers
Dirk
Re: Timeline - No Sharebuttons in article overwiew
Posted: Mon Jun 27, 2016 5:17 am
by Don Chambers
I just saw this thread. The Timeline theme is very unique and may not work the way other themes work. I will install that plugin on the demo and see if the theme can be modified to work as you expect.
Can you provide a URL to where it is NOT working as expected?
Re: Timeline - No Sharebuttons in article overwiew
Posted: Mon Jun 27, 2016 6:56 am
by onli
In the plugin,
this is how the overview check works:
Code: Select all
case 'frontend_display:html:per_entry':
if ($serendipity['view'] != 'entry') {
if (! serendipity_db_bool($this->get_config('overview', true))) {
// We are in overview mode and the user opted to not show the button
return true;
}
I don't think that can fail depending on the theme. But: The button is then appended to $eventData['display_dat']. Don, the timeline theme is probably not outputting that smarty variable?
Re: Timeline - No Sharebuttons in article overwiew
Posted: Mon Jun 27, 2016 8:22 am
by MarioH
Hi Don, thank you for having a look at this.
Here's the URL:
https://abouts9y.org
Re: Timeline - No Sharebuttons in article overwiew
Posted: Mon Jun 27, 2016 11:36 am
by yellowled
If I understand Timeline's entries.tpl correctly, $entry.plugin_display_dat is only emitted in “detailed entry view”. That would override the plugin setting (which is exactly what Mario is reporting).
YL
Re: Timeline - No Sharebuttons in article overwiew
Posted: Mon Jun 27, 2016 1:43 pm
by Don Chambers
yellowled wrote:If I understand Timeline's entries.tpl correctly, $entry.plugin_display_dat is only emitted in “detailed entry view”. That would override the plugin setting (which is exactly what Mario is reporting).
YL
That is absolutely correct. I didn't feel that sort of data made a lot of visual sense in the timeline format. However, just prior to releasing the theme, I added the option to format overviews in a more "blog like" manner, which is what abouts9y is using... I will modify the theme to emit $entry.plugin_display_dat for that view type.
Re: Timeline - No Sharebuttons in article overwiew
Posted: Tue Jun 28, 2016 5:36 pm
by yellowled
Don Chambers wrote:I didn't feel that sort of data made a lot of visual sense in the timeline format.
For what it's worth, I don't think it makes a lot of sense to emit social sharing buttons in entry teasers (which they essentially are in the timeline format). In my humble opinion, this plugin setting just does not make sense with any entry format.
I also think it is perfectly okay for a theme to “override” plugin behaviour. The issue here is that the theme has no way of informing the user why a plugin behaves unexpectedly.
YL