Timeline - No Sharebuttons in article overwiew

Skinning and designing Serendipity (CSS, HTML, Smarty)
Post Reply
MarioH
Regular
Posts: 232
Joined: Mon Jul 20, 2009 10:53 pm
Contact:

Timeline - No Sharebuttons in article overwiew

Post by MarioH » Sat Jun 25, 2016 5:19 pm

Hi,

within the new plugin serendipity_event_social you can configure to show the sharebuttons in article overviews. in Timeline the buttons are not displayed even the option in the plugin is set.

Regards
Mario

User avatar
Lux
Regular
Posts: 761
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: Timeline - No Sharebuttons in article overwiew

Post by Lux » Sun Jun 26, 2016 11:48 am

MarioH wrote:within the new plugin serendipity_event_social you can configure to show the sharebuttons in article overviews. in Timeline the buttons are not displayed even the option in the plugin is set.
Interesting that it works for me :-)

Strange.

Dirk

MarioH
Regular
Posts: 232
Joined: Mon Jul 20, 2009 10:53 pm
Contact:

Re: Timeline - No Sharebuttons in article overwiew

Post by MarioH » Sun Jun 26, 2016 12:25 pm

Hi,
Lux wrote:Interesting that it works for me
What do you mean? Do you have a blog with the Timeline-Theme and you have the buttons in the articel overview?

In other themes it works well, so I thought this has to be theme-related.

Regards
Mario

User avatar
Lux
Regular
Posts: 761
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: Timeline - No Sharebuttons in article overwiew

Post by Lux » Sun Jun 26, 2016 1:48 pm

MarioH wrote:In other themes it works well, so I thought this has to be theme-related.
Yes, it seems so.

Cheers

Dirk

User avatar
Don Chambers
Regular
Posts: 3633
Joined: Mon Feb 13, 2006 3:40 am
Location: Chicago, IL, USA
Contact:

Re: Timeline - No Sharebuttons in article overwiew

Post by Don Chambers » Mon Jun 27, 2016 5:17 am

I just saw this thread. The Timeline theme is very unique and may not work the way other themes work. I will install that plugin on the demo and see if the theme can be modified to work as you expect.

Can you provide a URL to where it is NOT working as expected?

User avatar
onli
Regular
Posts: 2214
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Timeline - No Sharebuttons in article overwiew

Post by onli » Mon Jun 27, 2016 6:56 am

In the plugin, this is how the overview check works:

Code: Select all

case 'frontend_display:html:per_entry':
   if ($serendipity['view'] != 'entry') {
       if (! serendipity_db_bool($this->get_config('overview', true))) {
           // We are in overview mode and the user opted to not show the button
           return true;
       }
I don't think that can fail depending on the theme. But: The button is then appended to $eventData['display_dat']. Don, the timeline theme is probably not outputting that smarty variable?

MarioH
Regular
Posts: 232
Joined: Mon Jul 20, 2009 10:53 pm
Contact:

Re: Timeline - No Sharebuttons in article overwiew

Post by MarioH » Mon Jun 27, 2016 8:22 am

Hi Don, thank you for having a look at this.

Here's the URL: https://abouts9y.org

User avatar
yellowled
Regular
Posts: 7002
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: Timeline - No Sharebuttons in article overwiew

Post by yellowled » Mon Jun 27, 2016 11:36 am

If I understand Timeline's entries.tpl correctly, $entry.plugin_display_dat is only emitted in “detailed entry view”. That would override the plugin setting (which is exactly what Mario is reporting).

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
Don Chambers
Regular
Posts: 3633
Joined: Mon Feb 13, 2006 3:40 am
Location: Chicago, IL, USA
Contact:

Re: Timeline - No Sharebuttons in article overwiew

Post by Don Chambers » Mon Jun 27, 2016 1:43 pm

yellowled wrote:If I understand Timeline's entries.tpl correctly, $entry.plugin_display_dat is only emitted in “detailed entry view”. That would override the plugin setting (which is exactly what Mario is reporting).

YL
That is absolutely correct. I didn't feel that sort of data made a lot of visual sense in the timeline format. However, just prior to releasing the theme, I added the option to format overviews in a more "blog like" manner, which is what abouts9y is using... I will modify the theme to emit $entry.plugin_display_dat for that view type.

User avatar
yellowled
Regular
Posts: 7002
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: Timeline - No Sharebuttons in article overwiew

Post by yellowled » Tue Jun 28, 2016 5:36 pm

Don Chambers wrote:I didn't feel that sort of data made a lot of visual sense in the timeline format.
For what it's worth, I don't think it makes a lot of sense to emit social sharing buttons in entry teasers (which they essentially are in the timeline format). In my humble opinion, this plugin setting just does not make sense with any entry format.

I also think it is perfectly okay for a theme to “override” plugin behaviour. The issue here is that the theme has no way of informing the user why a plugin behaves unexpectedly.

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

Post Reply