"Comment needs moderation"?

Skinning and designing Serendipity (CSS, HTML, Smarty)
Post Reply
User avatar
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

"Comment needs moderation"?

Post by blog.brockha.us » Tue Jul 10, 2012 2:33 pm

With 2k11 (but with bullet proof, too) I have the situation, that comments being moderated by AntiSpam plugins are shown as "your comment was successfully saved" (green) instead of "your comment needs moderation".

As far as I remember, there once was such a message (moderation needed). Do I remember wrong? Can we have this (again)? Or is that only a problem at my blogs?

It is very irritating for the commenter, so I think, seeing this message but no new comment.
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/

User avatar
garvinhicking
Core Developer
Posts: 30020
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: "Comment needs moderation"?

Post by garvinhicking » Tue Jul 10, 2012 2:50 pm

Hi!

changes have been made to the order of execution in the spamblock plugin to fix some issues that I don't properly remember. I think Timbalu (or onli?) fixed this with a larger restructuring of the code; it could be that this hinders setting the "moderate" status properly, and now maybe every spam is passed through the anti-spam measurements with a different attribute....

If you can, maybe try the spamblock plugin from s9y 1.6.0 just to see if that changes things for you?

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Re: "Comment needs moderation"?

Post by blog.brockha.us » Tue Jul 10, 2012 2:56 pm

I don't use the spamblock plugin ..

The comments are handled correctly and moderated indeed (by bee and bayes). I see them moderated in the admins comment list. So the handling is okay.

Only the user is not informed correctly about that fact and I wonder why.
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: "Comment needs moderation"?

Post by Timbalu » Tue Jul 10, 2012 7:12 pm

blog.brockha.us wrote:I don't use the spamblock plugin ...
You should! I still think it is no good to disable it at all, even when having other Antispam plugins installed. It is in core for a reason! :wink: See: http://board.s9y.org/viewtopic.php?f=10 ... #p10431063 So this might be the issue with that wrong note.

About that constant COMMENT_MODERATED...(is it that one?)... it was this thread, Garvin may remember, in http://board.s9y.org/viewtopic.php?f=10 ... #p10429094, as I don't think the wordfilter move to function or the killswitch fix could do any harm.
I then commited the former to master, AFAIR. My git.log says "HEAD is now at 8da26a1... en/de COMMENT_MODERATED lang changed"

edit:
I can't find any files in master or additional plugins which have "successfully saved"... is that the real message?
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Re: "Comment needs moderation"?

Post by blog.brockha.us » Tue Jul 10, 2012 7:52 pm

Timbalu wrote:You should! I still think it is no good to disable it at all, even when having other Antispam plugins installed.
I "should" not (as i don't need it) but I "have to" so it seems, if that really is the case. I think, this message handling should go to core so we are able to disable the normal SPAM Plugin.
Timbalu wrote:It is in core for a reason! :wink:
Well yes.. In my case: For historical reasons. ;) I really don't need it at all. ATM even Bayes has no real job in my blog..

Hmm.. I will investigate this.. If this code is in the SPAM plugin, I have to duplicate it and check, if it is installed. If not, I'll do the messaging code. But I think, this code should be located in the core, not in a plugin. There never will be a serious installation without any AntiSPAM functionality.. Hmm..
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/

User avatar
garvinhicking
Core Developer
Posts: 30020
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: "Comment needs moderation"?

Post by garvinhicking » Wed Jul 11, 2012 9:38 am

Hi!

Bee and the bayes plugins could simply not set the MODERATE variable like spamblock does. Maybe you can check those plugins if they perform the same like the antispam plugin. This is a minor thing that IMHO has no real place in the core, it's simply the comments messagestack that needs to be filled; that would be specific to each plugin, so I don't see how it could be abstracted into the core (well, actually it is in the core, because the messagestack is a core variable...)

(I have personally not used bee/Bayer so I can't comment on the code)
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Re: "Comment needs moderation"?

Post by blog.brockha.us » Wed Jul 11, 2012 12:12 pm

Okay, if it is only a variable not set correctly in the plugins, there has not to be code moved from the general antispam to the core.

But as far as I investigated it, Bayes and Bee are setting the same signals as the general antispam plugin does. But I will investigate this a little more. Thanks for input, Garvin.
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: "Comment needs moderation"?

Post by Timbalu » Wed Jul 11, 2012 1:41 pm

Could the missing messagestack thing be the issue for the mail sending too, if spamblock disabled?
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Re: "Comment needs moderation"?

Post by blog.brockha.us » Wed Jul 11, 2012 2:12 pm

I've tested a little further: Even with the general spam plugin installed I don't get the "moderated" message. The message stack is initiated by Bayes and Bee and everything else is done like it's done in the general plugin.

I investigated the "work flow" a little, too, what the template displays when, when the smarty vars are filled by s9ycore and so on. Everything looks absolutely fine, everything should work. But it doesn't.

Strange thing: Directly after enabling the general plugin, I saw a spam message *once* but never again. And I guess it was produced by the general antispam plugin (something about missing session).

I really don't get it yet, but don't have more time atm. Perhaps this evening again.
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: "Comment needs moderation"?

Post by Timbalu » Wed Jul 11, 2012 3:12 pm

Did you move the spamblock plugin in event plugins to be in front (first) of all other spam plugins?
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Re: "Comment needs moderation"?

Post by blog.brockha.us » Wed Jul 11, 2012 11:10 pm

No. To the last position (else it can't do any special stuff related to following plugins).

But I tested it with the generic plugin first: No change.
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/

Post Reply