style definitions within .tpl files

Skinning and designing Serendipity (CSS, HTML, Smarty)
Post Reply
hollow
Regular
Posts: 18
Joined: Mon Dec 20, 2004 11:16 pm

style definitions within .tpl files

Post by hollow »

Hello,
some .tpl files contain hardcoded style tags (i.e. plugin_calendar.tpl uses style="width: 100%" in the containing table). Isn't this considered to be bad style, because this normally should be part of the css file?

Regards,
hollow
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: style definitions within .tpl files

Post by garvinhicking »

Yes, this is bad style.

However we need to have it that way to stay backwards compatible with all the themes created out there; otherwise everyone needs to edit his template to put the "width" stuff into his CSS file.

The "width" doesn't really negatively affect the other CSS code, so it should just be a minor issue.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply