GGStatus 1.0

Creating and modifying plugins.
Post Reply
utak3r
Regular
Posts: 13
Joined: Tue May 15, 2007 4:11 pm
Location: Szczecin, Poland
Contact:

GGStatus 1.0

Post by utak3r »

Hello there :)

I've just uploaded to my homesite a new sidebar plugin for checking Gadu-Gadu status and its description. It's generally for polish users, as Gadu-Gadu is the most spreaded polish IM - and I don't think it's known anywhere else ;)

Anyway, you can go to here and download this plugin.
There's one small bug in it for now, if I remove it, is somewhere a common-known place for uploading plugins?

cheers, Peter.
sooner or later... you will meet the undertaker.
http://utak3r.pl
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: GGStatus 1.0

Post by garvinhicking »

Hi!

Great, thanks for getting involved! I'm sure this could get interesting!

If it is finished, I can upload it to Spartacus, our plugin repository. However I have a few suggestions before it can be uploaded:

1. Please replace polish code comments with english comments and polish output/error texts with translation constants - so that the code can also be maintained in the future easier.

2. If possible try to use the PEAR HTTP_Request class to open network connections to URLs. Have a look at the spartacus plugin or search plugins for "HTTP_Request" to see how it can be used easily by plugins. This will make your code a bit smaller, and less vulnerable to network problems because of PEARs abstraction

3. The output should better be made with XHTML compliant "<div>" containers instead of "<center>".

Very good work, thanks a lot!

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
utak3r
Regular
Posts: 13
Joined: Tue May 15, 2007 4:11 pm
Location: Szczecin, Poland
Contact:

Post by utak3r »

OK, thanks for your suggestions :)
After trying various engines I took this one, and I really would like to help.
I will review the code - plus I have to fight with one minor bug. When I will finish it, I'll give a sign :)

cheers, Peter.
sooner or later... you will meet the undertaker.
http://utak3r.pl
utak3r
Regular
Posts: 13
Joined: Tue May 15, 2007 4:11 pm
Location: Szczecin, Poland
Contact:

Post by utak3r »

OK, a couple of edits done:
  • 1. english code comments
    2. all error messages translatable
    3. fixed a bug (it was really slow, when a status description was empty)
    4. changed to DIVs
HTTP requests ain't PEARed yet... it's my next goal :)

You can download and watch it in action here:
GGStatus Serendipity plugin 1.1
sooner or later... you will meet the undertaker.
http://utak3r.pl
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

That looks great! Tell me when you think you'd like to put your plugin to spartacus!

Do you know how to use CVS? If you have a Sourceforge.net account, I could give you CVS access so that you could maintain your plugin on our CVS spartacus hosting, if you like.

Also tell us if you have difficulty fixing the bug, and what the bug exactly is - maybe we can help you.

Looking forward to your contributions, they will sure be helpful for our project! :)

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
utak3r
Regular
Posts: 13
Joined: Tue May 15, 2007 4:11 pm
Location: Szczecin, Poland
Contact:

Post by utak3r »

well...
PEARing already done :)
I had to use both HTTP_Request and a Net_Socket class, as a communication is a low level protocol - so it uses for example:

Code: Select all

$conn = &new Net_Socket();
$conn->connect($host, $port, null, 10)
$data = $conn->read(12);
$conn->write($data);
$conn->disconnect();
is this way ok? I've never used PEAR, but I think it should be ok (and it's working live).

BTW - I have a SF.net account, it's called 'utak3r' (I'm the co-author of Apophysis and am a polish translator of ed2k-gtk-gui). Yep, cvs access could be the easiest way, no troubling with bothering you each time I'll do something with this plugin :)

the link:
GGStatus plugin 1.2
sooner or later... you will meet the undertaker.
http://utak3r.pl
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

Sure, those Net_Socket connections are fine as well. :-)
BTW - I have a SF.net account, it's called 'utak3r' (I'm the co-author of Apophysis and am a polish translator of ed2k-gtk-gui). Yep, cvs access could be the easiest way, no troubling with bothering you each time I'll do something with this plugin :)
Great! To ease things up, I've just granted you CVS developer access to our "additional_plugins" CVS repository here:

http://php-blog.cvs.sourceforge.net/php ... l_plugins/

Since you know about SF.Net CVS access, I hope that info suffices? Make a checkout of the repository, and you can add your plugin there.I watch the commit logs, so if there are any problems I'll try to help :)

I've also added your initial revision there! :)

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
utak3r
Regular
Posts: 13
Joined: Tue May 15, 2007 4:11 pm
Location: Szczecin, Poland
Contact:

Post by utak3r »

OK, everything works 8)
sooner or later... you will meet the undertaker.
http://utak3r.pl
Post Reply