Hi,
is it possible to upgrade the spam protection plugin to support the following features?
- checking for "valid" e-mail-adress (somewhat@other.do.main.tld, a check of an existing top level domain and the at-sign "@" should be sufficient)
- checking for multiple exclamation marks
- checking for empty subjects
... more to come
Dirk
New features for spam protection plugin ...
-
- Core Developer
- Posts: 30022
- Joined: Tue Sep 16, 2003 9:45 pm
- Location: Cologne, Germany
- Contact:
Re: New features for spam protection plugin ...
Hi!
You cannot easily check TLDs, as they all might change. In a few months we may have ".xxx", and we'd have to re-edit the domain check every time. That would suck big time.
Ideally, you'd patch up your own spamblock protector with PHP code suitable for your own needs, but a generall workable solution is hard to find.
Best regards,
Garvin
This could be done, but personally I'm not fond of email verifiers, as they all tend to have flaws in identifying mail adresses at some point. Actually, serendipity already checks for "@" containment.- checking for "valid" e-mail-adress (somewhat@other.do.main.tld, a check of an existing top level domain and the at-sign "@" should be sufficient)
You cannot easily check TLDs, as they all might change. In a few months we may have ".xxx", and we'd have to re-edit the domain check every time. That would suck big time.
If you check for that, you can also check IF YOU ALWAYS USE UPPERCASE or check for multiple "???" signs, or check for " ? ? ? ? ?" or check for ". . . . .. ". Where does one draw the line? Thus this method of content checking is not a wise thing to apply. You'd also always run after you filter and customize it more often than where it actually helps.- checking for multiple exclamation marks
S9y does not allow subjects in comments...- checking for empty subjects
Ideally, you'd patch up your own spamblock protector with PHP code suitable for your own needs, but a generall workable solution is hard to find.
Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
-
- Regular
- Posts: 764
- Joined: Fri Aug 12, 2005 4:36 pm
- Location: Grüt, Zürich, Switzerland
- Contact:
Re: New features for spam protection plugin ...
My wife got a comment last night without "@"-sign. So, can you please tell me, how I can set it up?garvinhicking wrote:This could be done, but personally I'm not fond of email verifiers, as they all tend to have flaws in identifying mail adresses at some point. Actually, serendipity already checks for "@" containment.
You can always get a complete list at iana.org.You cannot easily check TLDs, as they all might change. In a few months we may have ".xxx", and we'd have to re-edit the domain check every time. That would suck big time.
Correct. That is difficult.If you check for that, you can also check IF YOU ALWAYS USE UPPERCASE or check for multiple "???" signs, or check for " ? ? ? ? ?" or check for ". . . . .. ". Where does one draw the line? Thus this method of content checking is not a wise thing to apply. You'd also always run after you filter and customize it more often than where it actually helps.
Maybe one can find a source for that somewhere in the net.
Aargh, you are right.S9y does not allow subjects in comments...
I think, the best would be a "regexp-checker" ...Ideally, you'd patch up your own spamblock protector with PHP code suitable for your own needs, but a generall workable solution is hard to find.
Dirk
-
- Core Developer
- Posts: 30022
- Joined: Tue Sep 16, 2003 9:45 pm
- Location: Cologne, Germany
- Contact:
Re: New features for spam protection plugin ...
Hi!
I just hacked a new config switch into the spamblock plugin that now allows to check for "@" and committed it to our 0.9 trunk/nighty.
And that list is quite large, I'm afraid a regular expressions would be very large.
Best regards,
Garvin
Sorry, I was mistaken. The "@" check in fact only replaced "@" with "[at]", and not validate it.My wife got a comment last night without "@"-sign. So, can you please tell me, how I can set it up?
I just hacked a new config switch into the spamblock plugin that now allows to check for "@" and committed it to our 0.9 trunk/nighty.
I know that. But one would have to edit this list over and over again, as the TLDs can change sometimes, right?You can always get a complete list at iana.org.You cannot easily check TLDs, as they all might change. In a few months we may have ".xxx", and we'd have to re-edit the domain check every time. That would suck big time.
And that list is quite large, I'm afraid a regular expressions would be very large.
I think the problem is this list would always change and grow endless - thus it's not a solution. Bayes filters would maybe work, but they're hard to implement on PHP-base.Maybe one can find a source for that somewhere in the net.
Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
-
- Regular
- Posts: 764
- Joined: Fri Aug 12, 2005 4:36 pm
- Location: Grüt, Zürich, Switzerland
- Contact:
Re: New features for spam protection plugin ...
The only intelligent way is, to import the list into a database table and to check against this table.garvinhicking wrote:I know that. But one would have to edit this list over and over again, as the TLDs can change sometimes, right?
And that list is quite large, I'm afraid a regular expressions would be very large.
Once a month the table could be updated.
I agree! But that does not satisfy me.garvinhicking wrote:I think the problem is this list would always change and grow endless - thus it's not a solution. Bayes filters would maybe work, but they're hard to implement on PHP-base.
Dirk
-
- Core Developer
- Posts: 30022
- Joined: Tue Sep 16, 2003 9:45 pm
- Location: Cologne, Germany
- Contact:
Re: New features for spam protection plugin ...
Hi!
Regards,
Garvin
Okay, that's a good idea! I'd like such an implementation, this should be workable.The only intelligent way is, to import the list into a database table and to check against this table.
Once a month the table could be updated.
Then you should best look at the serendipity_event_spamblock plugin and add your custom rules in that file directly...I agree! But that does not satisfy me.garvinhicking wrote:I think the problem is this list would always change and grow endless - thus it's not a solution. Bayes filters would maybe work, but they're hard to implement on PHP-base.
Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
-
- Regular
- Posts: 764
- Joined: Fri Aug 12, 2005 4:36 pm
- Location: Grüt, Zürich, Switzerland
- Contact:
Re: New features for spam protection plugin ...
Fine!garvinhicking wrote:Okay, that's a good idea! I'd like such an implementation, this should be workable.
I think, I live with the existing solution. If I do manual modifications, I have to repeat them every time an update comes.garvinhicking wrote:Then you should best look at the serendipity_event_spamblock plugin and add your custom rules in that file directly...
Thanks for your support.
Dirk
-
- Core Developer
- Posts: 30022
- Joined: Tue Sep 16, 2003 9:45 pm
- Location: Cologne, Germany
- Contact:
Re: New features for spam protection plugin ...
Hi!
Or make use of CVS/SVN so that you can update your blog without overwriting custom modifications?
Best Regards,
Garvni
I'm really sorry about that - you might want to have your manual code as an include which you could easily add?I think, I live with the existing solution. If I do manual modifications, I have to repeat them every time an update comes.
Or make use of CVS/SVN so that you can update your blog without overwriting custom modifications?
Best Regards,
Garvni
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
-
- Regular
- Posts: 764
- Joined: Fri Aug 12, 2005 4:36 pm
- Location: Grüt, Zürich, Switzerland
- Contact:
Re: New features for spam protection plugin ...
I am not quite sure, what I really want to do.garvinhicking wrote:I'm really sorry about that - you might want to have your manual code as an include which you could easily add?
Or make use of CVS/SVN so that you can update your blog without overwriting custom modifications?
Maybe I take my holiday and get clear about that
Thanks for your support.
Dirk