Page 1 of 1

BBCode: ordered list

Posted: Sat Oct 12, 2019 7:45 am
by Fabien
Hi,

I use the bbcode [ list=i] (no space of course) to add an ordered list in a comment… and I get an unordered list (http://www.chabreuil.com/Aurore/archive ... html#c3045)

An idea?

Thanks,
Fabien

Re: BBCode: ordered list

Posted: Sat Oct 12, 2019 10:40 am
by onli
Hi, so instead of the i you wrote a 1?

Re: BBCode: ordered list

Posted: Sat Oct 12, 2019 12:05 pm
by Fabien
"1" is the only ordered list that works.

Re: BBCode: ordered list

Posted: Sun Oct 13, 2019 8:53 am
by Fabien
Hi,

I think that I have found the problem.

The BBcode plugin uses a class for each type of ordered list: bb-list-ordered-d, bb-list-ordered-lr, bb-list-ordered-ur, bb-list-ordered-la, bb-list-ordered-ua.

But at the end of the plugin, only bb-list-ordered-d, bb-list-ordered-la and bb-list-ordered-ua

If I define bb-list-ordered-lr in my user.css, my list is correctly displayed. It works but it's probably better to add the classes in the plugin.

Have a good day.
Fabien

Re: BBCode: ordered list

Posted: Sun Oct 13, 2019 9:24 am
by Fabien
Hi,

I have corrected and tested my version of the plugin. Just add after line 300:

Code: Select all

.bb-list-ordered-lr{
	list-style-type:lower-roman
}
.bb-list-ordered-ur{
	list-style-type:upper-roman
}
Best regards.

Re: BBCode: ordered list

Posted: Sun Oct 13, 2019 4:30 pm
by onli
Great! could you provide a pull request on github, for https://github.com/s9y/Serendipity ?

Re: BBCode: ordered list

Posted: Sun Oct 13, 2019 4:38 pm
by Fabien
I have tried to do it but am not sure it's correct. It's my first use of GitHub. :oops:

Re: BBCode: ordered list

Posted: Sun Oct 13, 2019 4:57 pm
by onli
Sadly the PR contains a lot of different changes, but not the one wanted.

So the basic workflow: You go to https://github.com/s9y/Serendipity, click on fork (at the top right). Then you clone the new repository to your PC. Make the changes, then git add /file/that/changed, git commit -v and enter a good description, then git push. Then you go back to github to your forked repository and github will offer you to make a Pull Request.

Re: BBCode: ordered list

Posted: Sun Oct 13, 2019 6:38 pm
by thh
Done in https://github.com/s9y/Serendipity/pull/649, as far as I see.

Please test.

Re: BBCode: ordered list

Posted: Wed Oct 16, 2019 12:30 pm
by thh
Your change was tested and merged to our master branch. It has also been picked for our next bugfix release.

As the bbcode plugin is packaged with core, your changes won't be available immediately, but will be released with our next bugfix release 2.3.3.

Thank you very much for your work on Serendipity!