BBCode: ordered list

Creating and modifying plugins.
Post Reply
Fabien
Regular
Posts: 204
Joined: Wed Mar 15, 2006 1:02 pm
Location: Paris (France)
Contact:

BBCode: ordered list

Post by Fabien »

Hi,

I use the bbcode [ list=i] (no space of course) to add an ordered list in a comment… and I get an unordered list (http://www.chabreuil.com/Aurore/archive ... html#c3045)

An idea?

Thanks,
Fabien
Fabien Chabreuil (blog)
onli
Regular
Posts: 2822
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: BBCode: ordered list

Post by onli »

Hi, so instead of the i you wrote a 1?
Fabien
Regular
Posts: 204
Joined: Wed Mar 15, 2006 1:02 pm
Location: Paris (France)
Contact:

Re: BBCode: ordered list

Post by Fabien »

"1" is the only ordered list that works.
Fabien Chabreuil (blog)
Fabien
Regular
Posts: 204
Joined: Wed Mar 15, 2006 1:02 pm
Location: Paris (France)
Contact:

Re: BBCode: ordered list

Post by Fabien »

Hi,

I think that I have found the problem.

The BBcode plugin uses a class for each type of ordered list: bb-list-ordered-d, bb-list-ordered-lr, bb-list-ordered-ur, bb-list-ordered-la, bb-list-ordered-ua.

But at the end of the plugin, only bb-list-ordered-d, bb-list-ordered-la and bb-list-ordered-ua

If I define bb-list-ordered-lr in my user.css, my list is correctly displayed. It works but it's probably better to add the classes in the plugin.

Have a good day.
Fabien
Fabien Chabreuil (blog)
Fabien
Regular
Posts: 204
Joined: Wed Mar 15, 2006 1:02 pm
Location: Paris (France)
Contact:

Re: BBCode: ordered list

Post by Fabien »

Hi,

I have corrected and tested my version of the plugin. Just add after line 300:

Code: Select all

.bb-list-ordered-lr{
	list-style-type:lower-roman
}
.bb-list-ordered-ur{
	list-style-type:upper-roman
}
Best regards.
Fabien Chabreuil (blog)
onli
Regular
Posts: 2822
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: BBCode: ordered list

Post by onli »

Great! could you provide a pull request on github, for https://github.com/s9y/Serendipity ?
Fabien
Regular
Posts: 204
Joined: Wed Mar 15, 2006 1:02 pm
Location: Paris (France)
Contact:

Re: BBCode: ordered list

Post by Fabien »

I have tried to do it but am not sure it's correct. It's my first use of GitHub. :oops:
Fabien Chabreuil (blog)
onli
Regular
Posts: 2822
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: BBCode: ordered list

Post by onli »

Sadly the PR contains a lot of different changes, but not the one wanted.

So the basic workflow: You go to https://github.com/s9y/Serendipity, click on fork (at the top right). Then you clone the new repository to your PC. Make the changes, then git add /file/that/changed, git commit -v and enter a good description, then git push. Then you go back to github to your forked repository and github will offer you to make a Pull Request.
thh
Regular
Posts: 419
Joined: Thu Oct 26, 2006 2:38 pm
Location: Stuttgart, Germany
Contact:

Re: BBCode: ordered list

Post by thh »

Done in https://github.com/s9y/Serendipity/pull/649, as far as I see.

Please test.
thh
Regular
Posts: 419
Joined: Thu Oct 26, 2006 2:38 pm
Location: Stuttgart, Germany
Contact:

Re: BBCode: ordered list

Post by thh »

Your change was tested and merged to our master branch. It has also been picked for our next bugfix release.

As the bbcode plugin is packaged with core, your changes won't be available immediately, but will be released with our next bugfix release 2.3.3.

Thank you very much for your work on Serendipity!
Post Reply