Lightbox bug 2.4.0

Creating and modifying plugins.
User avatar
Don Chambers
Regular
Posts: 3633
Joined: Mon Feb 13, 2006 3:40 am
Location: Chicago, IL, USA
Contact:

Lightbox bug 2.4.0

Post by Don Chambers » Fri Feb 19, 2016 9:44 pm

I have a new demo site that will go live shortly. I just installed the latest lightbox plugin, version 2.4.0.

My entry images link to the full size image, as they should. The plugin configuration is all default values, but I noticed the last four plugin options are just empty div's.... The photo below shows the plugin config page of 2.4.0 (top) to another site running 2.0.3.

Image

The plugin is not working as expected - on the new site. I upgraded the site running 2.0.3 to 2.4.0 and it still works, leading me to believe the old configuration values are unchanged in the upgrade thereby making that site operational.

Any thoughts?

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: Lightbox bug 2.4.0

Post by Timbalu » Sat Feb 20, 2016 10:53 am

Good catch! Thanks.
Fixed in 2.4.1.
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
Don Chambers
Regular
Posts: 3633
Joined: Mon Feb 13, 2006 3:40 am
Location: Chicago, IL, USA
Contact:

Re: Lightbox bug 2.4.0

Post by Don Chambers » Tue Feb 23, 2016 8:00 pm

Doesn 't seem to be upgrading.....

On two different s9y installs, both running 2.4.0... Says upgrade to 2.4.1, yet after upgrade, version still says 2.4.0 and missing div's are still shown.

The date and time of serendipity_event_lightbox.php are as of my "upgrade", but the file clearly shows version 2.4.0, even though I see the commit of 2.4.1 in additional_plugins....

Ideas?

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: Lightbox bug 2.4.0

Post by Timbalu » Tue Feb 23, 2016 9:03 pm

I can't really say... There is/was an issue with the sync server, currently. Garvin is/was trying to debug it.
Do you say the sync from this morning did not create a valid xml file, so one cannot uprade with success?

If you need it now, deinstall and remove the plugin physically too and then install again a fresh copy by Spartacus. Does that work?
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
Don Chambers
Regular
Posts: 3633
Joined: Mon Feb 13, 2006 3:40 am
Location: Chicago, IL, USA
Contact:

Re: Lightbox bug 2.4.0

Post by Don Chambers » Tue Feb 23, 2016 10:25 pm

Probably a sync issue - I would rather make sure that issue has been resolved rather than manually deleting the plugin and installing the new one. I am still messing around with the site that I need the new plugin for, so there is no hurry. :)

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: Lightbox bug 2.4.0

Post by Timbalu » Fri Feb 26, 2016 5:07 pm

Did it work by now..?
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
Don Chambers
Regular
Posts: 3633
Joined: Mon Feb 13, 2006 3:40 am
Location: Chicago, IL, USA
Contact:

Re: Lightbox bug 2.4.0

Post by Don Chambers » Fri Feb 26, 2016 6:01 pm

Timbalu wrote:Did it work by now..?
No - the option to upgrade exists, but after the upgrade has "completed" I am still running 2.4.0 with the missing <div>'s

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: Lightbox bug 2.4.0

Post by Timbalu » Fri Feb 26, 2016 6:20 pm

Strange ... we should find out whats wrong and get Garvin to fix that..

Anyone else with the same?
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
yellowled
Regular
Posts: 7017
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: Lightbox bug 2.4.0

Post by yellowled » Fri Feb 26, 2016 6:21 pm

Don Chambers wrote:No - the option to upgrade exists, but after the upgrade has "completed" I am still running 2.4.0 with the missing <div>'s
Same here. Option for 2.4.1 pops up, update runs through without errors, after the update 2.4.0 with emptry divs.

By the way, there's another update for MagnificPopup (1.1.0) in case you need a reason to increment the version again.

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: Lightbox bug 2.4.0

Post by Timbalu » Fri Feb 26, 2016 9:54 pm

yellowled wrote:in case you need a reason to increment the version again.
Fine, but no good until Garvin had a look into the sync commands and their output again.

[It looked for me as of the xml file is not the same as before....]
Edit: I checked the xml and it looks good to me...
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: Lightbox bug 2.4.0

Post by Timbalu » Sat Feb 27, 2016 2:19 pm

Since the sync XLM file was ok, I investigated this sync issue down to netmirror.org, which hasn't synced the files yet - why ever. All other mirrors have.

http://netmirror.org/serendipity/additi ... ghtbox.php

If you set your Spartacus mirror path to anything other than netmirror it should work!
Please have a try.

Maybe it just hangs there on an unchanged timestamp, since the real file sync happened while the sync server had that glibc update issue... so we would just need to touch the files changed again...?

Edit:
There is something strange going on, since
view-source:http://netmirror.org/mirror/serendipity ... ent_de.xml
is ok, while
view-source:http://netmirror.org/mirror/serendipity ... ent_de.xml
is not.
Maybe we just have a (wrong synced) path issue here? Garvin?
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
Don Chambers
Regular
Posts: 3633
Joined: Mon Feb 13, 2006 3:40 am
Location: Chicago, IL, USA
Contact:

Re: Lightbox bug 2.4.0

Post by Don Chambers » Sat Feb 27, 2016 8:32 pm

I will wait for Garvin to respond before doing anything differently since I am not the only one having this problem. Would rather solve the actual problem I am having rather than using a substitute. In my case, there is no real hurry - the site in question is just a demo that is not yet ready to be seen anyway. :wink:

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: Lightbox bug 2.4.0

Post by Timbalu » Sat Feb 27, 2016 9:37 pm

Changing the mirror and sync paths is a total valid approach, though! They all are more than equal, and GitHub may be even more. :)
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
Don Chambers
Regular
Posts: 3633
Joined: Mon Feb 13, 2006 3:40 am
Location: Chicago, IL, USA
Contact:

Re: Lightbox bug 2.4.0

Post by Don Chambers » Sat Feb 27, 2016 9:51 pm

Just seems I can leave this site "as-is" to help us track down the netmirror issue until such time as I REALLY need the lightbox upgrade. :wink:

User avatar
garvinhicking
Core Developer
Posts: 30014
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Lightbox bug 2.4.0

Post by garvinhicking » Mon Mar 07, 2016 10:56 am

Hi!

Seems after my local server upgrade one component was missing, I re-added it, the sync should hopefully run through this night.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

Post Reply