Guestbook plugin

Creating and modifying plugins.
Post Reply
User avatar
kybernator
Regular
Posts: 126
Joined: Sat Sep 22, 2012 10:15 pm

Guestbook plugin

Post by kybernator » Sat May 09, 2015 3:43 pm

There are some questions I would like to ask about the guestbook plugin. It could well be that they answers have to do with the plugin, it could also well be that the answers have to do with the theme used. Also, with me having made a stupid configuration mistake. :roll:

My current testing page is http://efg-test.xf1.de/index.php?/pages/guestbook.html

1. On the bottom of the page, there are 3 colored areas with an info-icon displaying information, the third of them is for the Captcha, for example. Below them, there is an empty fourth field. What is this, why is it there, is it supposed to be there?

2. The input field for the user's homepage, if made visible, does not have a label like Name and E-Mail fields have.

3. Is there a way to offer a "preview" to the user before actually sending the entry?

4. In the line "FIRST | PREVIOUS ( Seite 1 von 1 ) NEXT | LAST", the navigation is in English text. is there an alternative for e.g. German, or an international solution using "tape recorder buttons" (|<, <<,>>,>|)?
[Yes, I would expect most web using people to understand that much English - and no, I know from personal experience some really don't. True story.]

5. In the info fields mentioned above, the info icon is a font icon from from "fontello". In the line

[username] wrote at CLOCKICON [day],[ date], [time],

CLOCKICON is a gif - shouldn't it rather be a font icon as well (or be suppressed)?

Thank you for your time, and for your work.

Regards,

Bernd

User avatar
yellowled
Regular
Posts: 7007
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: Guestbook plugin

Post by yellowled » Sat May 09, 2015 4:00 pm

It would actually be interesting to see if all these also happen in 1.x, but since the guestbook plugin is very rarely used, I'm not sure we'll find someone using that combination.
kybernator wrote:1. On the bottom of the page, there are 3 colored areas with an info-icon displaying information, the third of them is for the Captcha, for example. Below them, there is an empty fourth field. What is this, why is it there, is it supposed to be there?
That's an empty comment direction. No idea how that happens, might be related to changes in 2.x.
kybernator wrote:2. The input field for the user's homepage, if made visible, does not have a label like Name and E-Mail fields have.
It does have a label (element), but that does not have content. Might be using a deprecated language constant.
kybernator wrote:3. Is there a way to offer a "preview" to the user before actually sending the entry?
Since the form does not have a preview button, I think it's safe to assume “No”, but I've never really used the guestbook plugin.
kybernator wrote:4. In the line "FIRST | PREVIOUS ( Seite 1 von 1 ) NEXT | LAST", the navigation is in English text. is there an alternative for e.g. German, or an international solution using "tape recorder buttons" (|<, <<,>>,>|)?
I would assume that's sloppy coding that no one ever bothered to fix. There are actual lang constants for this in the lang files for the plugin, at least for next/prev (which are redundant because those already exist in the core lang files).
kybernator wrote:5. In the info fields mentioned above, the info icon is a font icon from from "fontello". In the line

[username] wrote at CLOCKICON [day],[ date], [time],

CLOCKICON is a gif - shouldn't it rather be a font icon as well (or be suppressed)?
That's because they have a different origin. The direction icon is a core functionality (and thus, handled the 2.0 way with an icon font), the clock icon is a plugin functionality.

The guestbook plugin has not been adapted to 2.0 yet for various reasons. One of them is that … erm … well … no one really uses it anymore, so it's not high on our priority list.

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: Guestbook plugin

Post by Timbalu » Sat May 09, 2015 4:25 pm

kybernator wrote: 1. On the bottom of the page, there are 3 colored areas with an info-icon displaying information, the third of them is for the Captcha, for example. Below them, there is an empty fourth field. What is this, why is it there, is it supposed to be there?
This is the input field for the captcha!
yellowled wrote:That's an empty comment direction. No idea how that happens, might be related to changes in 2.x.
This is something else. It is the homepage field (by option) and really has a missing label. It is

Code: Select all

<label for="serendipity_commentform_url">{$CONST.URL}</label>
Has {$CONST.URL} been disabled with 2.0?
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: Guestbook plugin

Post by Timbalu » Sat May 09, 2015 4:57 pm

kybernator wrote:3. Is there a way to offer a "preview" to the user before actually sending the entry?
Currently: No! (Probably: Yes, if that is coded)
kybernator wrote:4. In the line "FIRST | PREVIOUS ( Seite 1 von 1 ) NEXT | LAST", the navigation is in English text. is there an alternative for e.g. German, or an international solution using "tape recorder buttons" (|<, <<,>>,>|)?
Guestbooks entrypaging is already langified, as far as some translators did (german is!), but uses the FIRST | PREVIOUS - NEXT | LAST as empty placeholders. You will notice, when entrypaging has actually something to page about. No alternate currently.
kybernator wrote:5. In the info fields mentioned above, the info icon is a font icon from from "fontello". ... CLOCKICON is a gif - shouldn't it rather be a font icon as well (or be suppressed)?
No, since this is much older and font-icon themes are rare. And they would need to have this implemented. And it wouldn't be easy to find out automatically. To provide its own icon-font would need more occurrences to be worthwhile.
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
yellowled
Regular
Posts: 7007
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: Guestbook plugin

Post by yellowled » Sat May 09, 2015 5:09 pm

Timbalu wrote:Has {$CONST.URL} been disabled with 2.0?
If there ever was a $CONST.URL, it has been replaced by $CONST.HOMEPAGE a long time ago. (Haven't checked the lang files forensics, though.)

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: Guestbook plugin

Post by Timbalu » Sat May 09, 2015 5:14 pm

None in 1.6, 1.7, or 2.0. Strange! ;-) I'll fix guestbook.
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

Post Reply