Timbalu wrote:Was this a matter of an updated webkit? Or does it even work with "older" webkit engined Browsers (lets say ~1 year old...)?
I have no older WebKit browser available, so I could not even test it.
It's not as if the issue is fixed just by an updated WebKit (or lightbox plugin, for that matter) – it still needs
a CSS fix (in form of display: block on .serendipity_image_link), and while that is kind of similar to your previous fix, I assume this to be way less prone to error in relation to other
(theme) styles just because of the fact that it does not generate a :before pseudo element or require a @media query.
So if you're asking “Will this work in older versions of Chrome or Safari?“ – I don't know. I don't consider it to be a problem in Chrome since it's an evergreen browser. Unfortunately, Safari is not. But since there is no good way to test that and no good way to only use a different fix for older Safaris (if that were necessary, which we don't know), I'd say we apply the new fix and wait for people to report errors (which I don't anticipate ever happening).
I would like to proceed as follows:
- add the fix to the lightbox plugin instead of the old fix in fixchrome.css for the time being
- add it to master in /templates/default/style_fallback.css so that we can remove fixchrome.css from the plugin once 2.1 is released
Does that seem reasonable?