Page 1 of 1

Setting default for new config options in plugin

Posted: Sat Aug 30, 2014 12:23 am
by FishNiX
@onli -

You mentioned I should specify the default here

Code: Select all

$this->get_config('display_helper', true)
I've made a change to the s9ymarkup plugin, can you tell me where I should do that?

https://github.com/fishnix/Serendipity/ ... kup_option

Thanks!
:mrgreen:

Re: Setting default for new config options in plugin

Posted: Sat Aug 30, 2014 9:41 am
by Timbalu
Sorry, I just drop in...
Don't forget to change to PLUGIN_EVENT_S9YMARKUP_* on line 73/73. Eliminating these messages by config option is a good idea. I think the place chosen down in 'frontend_comment' is right. And add a serendipity_db_bool() around it too.

Re: Setting default for new config options in plugin

Posted: Sat Aug 30, 2014 11:11 am
by onli
Timbalu wrote:And add a serendipity_db_bool() around it too.
That shouldn't be necessary here.
FishNiX wrote:can you tell me where I should do that?
Sure, I made a comment on the commit.