Feed selection of syndication plugin

Creating and modifying plugins.
Post Reply
User avatar
onli
Regular
Posts: 2254
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Feed selection of syndication plugin

Post by onli » Mon Jun 09, 2014 8:27 pm

I mentioned this in http://board.s9y.org/viewtopic.php?f=4&t=19956.

There are a number of feed-formats I don't think we should support any longer in the plugin. These are:

RSS 0.91
RSS 1.0
Atom 0.3
opml1.0*

I would like to remove these, at least from the snydication plugin option list, but also from the core where it seems hasslefree to do so. Is anyone here still using these and would have an issue with that? Garvin, do you know of existing usecases?

The remaining selection would be:

RSS 2
Atom 1.0
and the same for comments

--------------------

One could probably also argue for the removal of Atom 1.0, and rather have it as switch (to either list an Atom or a RSS feed). I would like this and think this should mean no problem for no one, as the current readers should all support both, but it is nothing that has to be done. But we could then change the plugin html to not be a generic list, but be either an entry feed (RSS or Atom, and subtome using) and an optional comment feed (RSS or Atom) button, that could be quite nice. Maybe with fitting icons and all.

Opinions on this?


*Note that OPML really should stay supported in the core, it could be useful as an export/import format. I see just no place for it in a visitor-facing subscribe plugin.

User avatar
garvinhicking
Core Developer
Posts: 30020
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Feed selection of syndication plugin

Post by garvinhicking » Thu Jun 12, 2014 3:11 pm

Hi!

I'm okay with removing the frontend-facing options for this in the syndication plugin. However the formats themselves should still work, I would not want to remove the code for this. In the past there were some old aggregators that fetched code in those formats, and I don't see a reason to break this.

I'd like to retain the option to offer RSS *and* Atom feeds, I think we have no reason to force users to use one. IMO offering flexibility is better than removing choices.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
onli
Regular
Posts: 2254
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Feed selection of syndication plugin

Post by onli » Thu Jun 12, 2014 4:10 pm

Ok, great.
garvinhicking wrote: In the past there were some old aggregators that fetched code in those formats, and I don't see a reason to break this.
I assumed this case wouldn't exist anymore, and less code is good. But it will stay then.
garvinhicking wrote:I'd like to retain the option to offer RSS *and* Atom feeds
You mean at the same time, so you are against the switch and prefer to emit both feeds at the same time, as well in the head as in the sidebar plugin? Note that we could still have always both in the head even if we want to have only one at the same time in the plugin.

If yes, optional show both in the plugin, I would then code it like this:
Given that the bigimg-option and subtome is activated: By default, only RSS is activated and wrapped with img and subtome. If Atom is activated as well, the plugin would show the atom feed as a link button under the big img, like right now - but subtome-wrapped. If only Atom is activated, this feed would be wrapped with the img/subtome (I think this makes clear why I would prefer only to show one and switch the format, the logic is easier).

I will have to change the subtomewrapper to really use the linked feed and not use autodiscovery.

Comment feeds as text button under those two, optional like now.

User avatar
onli
Regular
Posts: 2254
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Feed selection of syndication plugin

Post by onli » Sun Jun 15, 2014 9:42 pm

Addition: Feedburner. This is right now heavily customizable, and very separate. I could include it into the new flow https://github.com/s9y/Serendipity/comm ... 6de226b704, linking to the feedburner-feed (with subtome when activated), and simply replace the big/subtome-image with the feedburner image/counter if that fb-img-option is active. Didn't touch it yet though.

Also, could you have a look at https://github.com/s9y/Serendipity/comm ... 6de226b704 or rather test the new version? I dislike right now that the user could deactivate RSS and Atom (what the code would catch and print RSS anyway), do you see a better solution (I only see the switch as a solution…)?

User avatar
garvinhicking
Core Developer
Posts: 30020
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Feed selection of syndication plugin

Post by garvinhicking » Tue Jun 17, 2014 12:27 pm

I can't wrap my head around this right now, but maybe we could chat about this on the mumble meetup?
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
onli
Regular
Posts: 2254
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Feed selection of syndication plugin

Post by onli » Tue Jun 17, 2014 1:20 pm

Sure. Maybe it will be helpful or that if I do all the modifications till then, and we can discuss which you don't want to have like that, and I revert that then?

User avatar
garvinhicking
Core Developer
Posts: 30020
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Feed selection of syndication plugin

Post by garvinhicking » Tue Jun 17, 2014 1:24 pm

onli wrote:Sure. Maybe it will be helpful or that if I do all the modifications till then, and we can discuss which you don't want to have like that, and I revert that then?
Sure, I'm fine with you sorting out your "best proposal" and then we can start cherry-picking and dissecting it. Works for me. Maybe even better to be able to see it in front of me :)
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
onli
Regular
Posts: 2254
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Feed selection of syndication plugin

Post by onli » Sun Jun 22, 2014 4:33 pm


Post Reply