[podcasting] invalid token

Creating and modifying plugins.
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: [podcasting] invalid token

Post by garvinhicking »

Hi!

Sadly I was unable to find a HEX editor with which to inspect this properly.

However, it seems the feedvalidator still uses a cached/old version of your feed, because it still complains about:

"<audio controls preload="none"> "

This is invalid XML, it needs to read:

"<audio controls="something" preload="none"> "

because in XML, any tag attributes need to have values.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Lux
Regular
Posts: 764
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: [podcasting] invalid token

Post by Lux »

garvinhicking wrote:Sadly I was unable to find a HEX editor with which to inspect this properly.

However, it seems the feedvalidator still uses a cached/old version of your feed, because it still complains about:

"<audio controls preload="none"> "
I added it again, after I saw the same behaviour.
garvinhicking wrote:This is invalid XML, it needs to read:

"<audio controls="something" preload="none"> "

because in XML, any tag attributes need to have values.
Ok, this was default in the plugin, I did not touch that line, but I will add it.

With DeimHart (deimhart.net) we have the same result.

Cheers

Dirk

P.S.: For reference: http://www.w3.org/TR/html-markup/audio.html
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: [podcasting] invalid token

Post by Timbalu »

Mine says now: <!-- podcastplayerstart --><audio controls="controls" preload="none">
(There it still needs to disable nl2p...)

Did you try with my example in the entry without using the podcast plugin, to check where the error comes from? (is this possible?)

Remember cache can be avoided if you use
http://www.radiotux.de/index.php?/feeds/atom.xml&foo=0 (counting up in debug modus..., I think)
Last edited by Timbalu on Tue Mar 27, 2012 11:25 am, edited 1 time in total.
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
Lux
Regular
Posts: 764
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: [podcasting] invalid token

Post by Lux »

Timbalu wrote:Mine says now: <!-- podcastplayerstart --><audio controls="controls" preload="none">
(There it still needs to disable nl2p...)
It is disabled.
Timbalu wrote:Did you try with my example in the entry without using the podcast plugin, to check where the error comes from? (is this possible?)
No it is not. This is a podcast, downloaded several times per day.
Timbalu wrote:Mine says: <!-- podcastplayerstart --><audio controls="controls" preload="none">

Remember cache can be avoided if you use
http://www.radiotux.de/index.php?/feeds/atom.xml&foo=0 (counting up in debug modus..., I think)
What is the difference between your line and the one you found in the feed?

Cheers

Dirk
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: [podcasting] invalid token

Post by Timbalu »

None. As this was an answer to Garvin... (who found <audio controls preload="none">)

Yes, I know that you need the podcast plugin in general, but my guess was just to test... would be just a few seconds... to see if it is the <source> <a href> <source> <a href> or a missing space between the html comment and the next tag, for example.

The validator claimed line 102 </p><ul> - (oh yes I see that this is the previouses entry..., never mind)

Edit:
Btw, I remember atom to be be less good as rss 2.0, do the really need the atom feed?
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: [podcasting] invalid token

Post by garvinhicking »

Hi!

OK, now the controls atom feed error is gone. The error now remainig is this </p></ul> thing. This really seems to stem from the nl2p or nl2br plugin?!

IMHO this would occur both in the RSS *and* the ATOM feed *and* the HTML view. So this is a problem in the structure of the text, and what nl2br/p converts it to. We'd need to check that further; Ian, did you or onli patch up this nl2X functionality? Maybe you can help to debug this?

You could copy+paste the exact entry as you have it in your s9y entry here for us to try to reproduce it inside the nl2X plugin.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: [podcasting] invalid token

Post by Timbalu »

garvinhicking wrote:Ian, did you or onli patch up this nl2X functionality? Maybe you can help to debug this?
This is 1.6 nl2br/p, so I didn't touch it. I expect this is one of the rare and rather complicated cases, where the p replace does not produce valid data... (one of the reasons I did this nl2br <nl> ... </nl> tag)
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
Lux
Regular
Posts: 764
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: [podcasting] invalid token

Post by Lux »

garvinhicking wrote:You could copy+paste the exact entry as you have it in your s9y entry here for us to try to reproduce it inside the nl2X plugin.
Sure, here it is (I think it was written with an WYSIWYG-Editor, NL2BR is disabled for this article):

Code: Select all

<p>In der Februar-Ausgabe von RadioTux sprechen <a href="https://plus.google.com/117712032058288132040" target="_blank" title="Denny bei g+">Denny</a>, <a href="https://plus.google.com/113490624731194193134" target="_blank" title="Leszek bei g+">Leszek</a> und <a href="https://plus.google.com/103422154498784709654/" target="_blank" title="Sebastian bei g+">Sebastian</a> über Unitiy.</p>
<p>Ubuntu hat Unity als eigene Desktop-Umgebung für Ubuntu gestartet. Da aber nicht jeder Ubuntu nutzt ist es nicht selbstverständlich, dass man bereits einen solchen Desktop gesehen hat. Einer von vielen Gründen sich näher mit der Desktopumgebung zu beschäftigen.</p>
<p> </p>
<p>Links:</p>
<ul>
<li><a href="http://unity.ubuntu.com/" target="_blank" title="Webseite von Unity">Unity</a> - Webseite von Unity</li>
<li><a href="http://www.ubuntu.com/" target="_blank" title="Ubuntu Webseite">Ubuntu</a> - Bisher die einzige Distribution die Unity einsetzt</li>
<li><a href="http://www.canonical.com/" target="_blank" title="Canonical Webseite">Canonical</a> - Die Firma hinter Unity und Ubuntu</li>
</ul>

<a href="http://archiv.radiotux.de/sendungen/radiotux/2012-02-29.RadioTux.Magazin.Februar2012.mp3">Februar-Sendung MP3</a>
<a href="http://archiv.radiotux.de/sendungen/radiotux/2012-02-29.RadioTux.Magazin.Februar2012.ogg">Februar-Sendung Ogg</a>
Cheers

Dirk
Last edited by Lux on Tue Mar 27, 2012 9:00 am, edited 2 times in total.
Lux
Regular
Posts: 764
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: [podcasting] invalid token

Post by Lux »

Timbalu wrote:Btw, I remember atom to be be less good as rss 2.0, do the really need the atom feed?
Does S9y offer an Atom feed? If yes, it should be valid.

Cheers

Dirk
onli
Regular
Posts: 2828
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: [podcasting] invalid token

Post by onli »

Hi Dirk
I think that's the wrong entry. The one with the error is "RadioTux-Sendung Januar 2012". The one you posted seems to be fine.

Do you really want to produce xhtml?
Lux
Regular
Posts: 764
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: [podcasting] invalid token

Post by Lux »

onli wrote:I think that's the wrong entry. The one with the error is "RadioTux-Sendung Januar 2012". The one you posted seems to be fine.
Hi Malte,

then this will be the right one:

Code: Select all

<strong>Back to the roots...</strong>

und damit auch willkommen zurück. Auch wir sind aus unsererem Winterschlaf erwacht und präsentieren uns in alter Frische. An unsere Infrasturktur wird im Hintergrund immer noch fleißig gebaut, einiges ist aber schon geschafft. In unserer aktuellen Januar Sendung beschäftigen wir uns mit einem Ausblick auf das Jahr 2012.

Wir wünschen euch viel Spaß!

<ul>
<li>Hardware

<ul>
<li>Die "Convertibles" kommen.</li>
<li><a href="http://www.asus.de/Eee/Eee_Pad/Eee_Pad_Transformer_Prime_TF201/">ASUS Transformer Prime</a> - Tablett und Netbook</li>
<li><a href="http://www.netbooknews.de/59956/fujitsu-lifebook-konzept-studie-will-notebook-smartphone-und-mehr-in-einem-gerat-vereinen/">Fujitsu Lifebook Studie</a></li>
<li><a href="http://www.motorola.com/Consumers/XW-EN/Consumer-Products-and-Services/Mobile-Phones/Motorola-ATRIX-XW-EN">Motorola Atrix</a> - Handy mit Netbook-Dockingstation</li>
<li><a href="http://www.ubuntu.com/tv">Ubuntu TV</a></li>
<li><a href="http://www.cesweb.org/">CES 2012 </a></li>
</ul></li>
<li>Software

<ul>
<li>Gnome</li>
<li>Abspaltung <a href="http://cinnamon.linuxmint.com/">Cinnamon</a></li>
<li>KDE</li>
<li><a href="http://www.kde.org/announcements/4.8/">KDE 4.8 Release</a> QML hält Einzug in KDE, <a href="http://www.phoronix.com/scan.php?page=news_item&px=MTAzNjI">Eigener Fenstermanager auf KWin Basis mit QML</a></li>
<li>XFCE</li>
<li>LXDE </li>
<li>Zukunftspläne, <a href="https://lists.launchpad.net/lubuntu-desktop/msg05776.html">LXPanel2 geplant</a>, PCManFM 1.0  </li>
<li>Wayland?</li>
</ul></li>
<li>Betriebssystem

<ul>
<li>Suse</li>
<li>Ubuntu</li>
<li><a href="http://www.fedoraproject.org">Fedora</a></li>
<li>Debian</li>
<li>andere</li>
<li>Trends 2011 <a href="http://distrowatch.com/">DistroWatch.com</a></li>
</ul>



<ol>
<li>Linux Mint</li>
<li>Ubuntu</li>
<li>Fedora</li>
<li>Debian</li>
<li>openSUSE</li>
<li>Arch</li>
<li>PCLinuxOS</li>
<li>CentOS</li>
<li>Puppy</li>
<li>Mandriva</li>
<li><a href="http://deimhart.net/index.php?/archives/145-Folge-31-Sabayon-Linux.html">Sabayon</a></li>
</ol>

<ul>
<li>Trend <a href="http://de.wikipedia.org/wiki/Rolling_Release">Rolling Release?</a></li>
</ul></li>
<li>soziales

<ul>
<li><a href="http://de.wikipedia.org/wiki/Stop_Online_Piracy_Act">SOPA</a> - siehe auch <a href="http://wissen.dradio.de/netz-reporter-xl-sopa-acta-und-co.126.de.html?dram:article_id=14638">DRadio Wissen Sendung</a></li>
<li>"War on general purpose computing" - Haben wir in Zukunft nur noch Appliances ?</li>
<li><a href="http://en.wikipedia.org/wiki/Windows_8#Secure_Boot">Secure Boot</a> - <a href="http://www.heise.de/open/artikel/Die-Woche-Freie-Software-gegen-die-Entmuendigung-der-Anwender-1417513.html">Entmündigung des Anwenders am eigenen PC</a></li>
</ul></li>
<li>Events</li>
<li>Trends 2011 (selbst wahrgenommen), werden sie sich 2012 fortsetzen?

<ul>
<li>E-Book-Reader</li>
<li>Tabletts </li>
<li>Android  </li>
</ul></li>
</ul>

<a href="http://archiv.radiotux.de/sendungen/radiotux/2012-01-31.RadioTux.Magazin.Januar2012.mp3">2012-01-31.RadioTux.Magazin.Januar2012.mp3</a>
<a href="http://archiv.radiotux.de/sendungen/radiotux/2012-01-31.RadioTux.Magazin.Januar2012.ogg">2012-01-31.RadioTux.Magazin.Januar2012.ogg</a>
onli wrote:Do you really want to produce xhtml?
Which opportunities do we have with around 2000 articles migrated from Wordpress?

Cheers

Dirk
onli
Regular
Posts: 2828
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: [podcasting] invalid token

Post by onli »

Lux wrote:
onli wrote:I think that's the wrong entry. The one with the error is "RadioTux-Sendung Januar 2012". The one you posted seems to be fine.
Hi Malte,

then this will be the right one:
Yep, that's the right one.
Lux wrote:
onli wrote:Do you really want to produce xhtml?
Which opportunities do we have with around 2000 articles migrated from Wordpress?
None at all, when editing the entries themselves. But the atom-feed says the content is xhtml, whereas the doctype of the site is html - not at all related to the issue at hand, as the </p>in that place is also invalid html, but that explains the issues with the audio-element.
Just wanted to mention it, it will lead to more validation errors in the future, but it shouldn't make the feed unuseable.
Lux
Regular
Posts: 764
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: [podcasting] invalid token

Post by Lux »

onli wrote:None at all, when editing the entries themselves. But the atom-feed says the content is xhtml, whereas the doctype of the site is html - not at all related to the issue at hand, as the </p>in that place is also invalid html, but that explains the issues with the audio-element.
Just wanted to mention it, it will lead to more validation errors in the future, but it shouldn't make the feed unuseable.
Thanks!

What about changing the doctype?

Cheers

Dirk
onli
Regular
Posts: 2828
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: [podcasting] invalid token

Post by onli »

I'd rather tell the feed that the content is html5, not xhtml. But it's possible i'm wrong, i find no documentation covering this. The html5-specs read like xmlns=xhtml is correct in that place - but then the validator is wrong. Maybe the best way would be to alter the feed to include the article in content as cdata (link) with no html-declaration at all. But that should your template do for you. I'll ask YL.
onli
Regular
Posts: 2828
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: [podcasting] invalid token

Post by onli »

PS: I can confirm the bug. nl2p inserts a wrong </p> before a <ul> which itself is in a <ul>.
Post Reply