Prevent empty body & extended body in entrycheck_plugin

[gregman]

Hi there,

as mentioned in the subject, I added two new options to the entry_check plugin; one for preventing empty entry bodies, one for preventing empty extended bodies. German, english and frensh language files updated as well. Maybe someone's gonna need these features too. Shall I upload it anywhere?

Regards
Greg

[yellowled]

as mentioned in the subject, I added two new options to the entry_check plugin; one for preventing empty entry bodies, one for preventing empty extended bodies. German, english and frensh language files updated as well. Maybe someone's gonna need these features too. Shall I upload it anywhere?

Sounds promising. Usually, Garvin and the coder guys prefer a diff (a file compaing the changes made compared to the current version). Can you provide a diff file? (I think it has to be a unified diff, but I'm not 100% sure.)

YL

[gregman]

Is there an app for this?

[yellowled]

Is there an app for this?

Depends on your OS.

YL

[garvinhicking]

Hi!

The complete ZIP file would also do. Preferably linked on a public URL so I can wget it, which makes updating it much more easy instead of needing to first extract a ZIP from an email, save it to disk, upload it to my server, and extract it there

Regards,
Garvin

[gregman]

Hi Garvin,

here it is: http://www.studium-auskunft.de/uploads/ ... ycheck.zip

As I experienced some weired behavior I had to fix some bugs too. Hope everything is working now.

Regards
Greg

[garvinhicking]

Hi!

Great. I saw you changed the boolean logic of the checks? That's odd, somebody should have noticed that, if the logic were inverted? Anyhow, I trust you to have checked that and got it working for you, so I committed your patch. Thanks a lot!

Regards,
Garvin

[gregman]

Yes, this was IMHO a bug. In the language files it says e.g.

Code: Select all

@define('PLUGIN_EVENT_ENTRYCHECK_EMPTYTITLE', 'Do not allow empty titles');
@define('PLUGIN_EVENT_ENTRYCHECK_EMPTYTITLE_DESC', 'If set to "true", an entry must not have an empty title.');

So you have to prevent saving the entry, if the config variables are set to true.

Regards,
Greg

EDIT: P.S.: I'm done with the ajax enhancement of the karma_plugin, http://board.s9y.org/viewtopic.php?f=11 ... #p10429061