Page 1 of 1
Diff for identi.ca in serendipity_event_findmore
Posted: Tue May 31, 2011 10:28 am
by seraphyn
plugin_findmore.tpl:
Code: Select all
8,12d7
<
< {if NOT $findmore_disabled_services.identica}
< <a href="http://identi.ca/notice/new?status_textarea={$entrydata.title|escape:url}%20-%20{$entrydata.url|escape:url}" title=Identi.ca"><img src="{$entrydata.path}identica.png" title="Identi.ca" alt="Identi.ca" class="socialbkmark" /></a>
< {/if}
<
serendipity_event_findmore.php
Code: Select all
76a77
> 'identica' => 'Identi.ca',
Identi.ca-Pic attached
Re: Diff for identi.ca in serendipity_event_findmore
Posted: Wed Jun 01, 2011 10:28 am
by garvinhicking
Hi!
Great! Added to CVS.
Regards,
Garvin
Re: Diff for identi.ca in serendipity_event_findmore
Posted: Fri Jun 10, 2011 6:53 pm
by seraphyn
Hi Garvin,
one Error:
[quote="seraphyn"]plugin_findmore.tpl:
Code: Select all
8,12d7
<
< {if NOT $findmore_disabled_services.identica}
< <a href="http://identi.ca/notice/new?status_textarea={$entrydata.title|escape:url}%20-%20{$entrydata.url|escape:url}" title=Identi.ca"><img src="{$entrydata.path}identica.png" title="Identi.ca" alt="Identi.ca" class="socialbkmark" /></a>
< {/if}
<
title =identi.ca" is wrong.
There should be an ".
Did you need a new diff?
chris
Re: Diff for identi.ca in serendipity_event_findmore
Posted: Fri Jun 10, 2011 7:06 pm
by seraphyn
Garinv,
diff including the wrong set in twitter for rel="nofollow" and identi.ca wrong title:
plugin_findmore.tpl:
Code: Select all
5c5
< <a rel="nofollow" href="http://twitter.com/home?status={$entrydata.title|escape}%20-%20{$entrydata.url|escape:url}" title="Twitter"><img src="{$entrydata.path}twitter.png" title="Twitter" alt="Twitter" class="socialbkmark" /></a>
---
> <a href="http://twitter.com/home?status={$entrydata.title|escape}%20-%20{$entrydata.url|escape:url}" title="Twitter"><img src="{$entrydata.path}twitter.png" title="Twitter" alt="Twitter" rel="nofollow" class="socialbkmark" /></a>
105c105
< <a rel="nofollow" href="http://identi.ca/notice/new?status_textarea={$entrydata.title|escape:url}%20-%20{$entrydata.url|escape:url}" title="Identi.ca"><img src="{$entrydata.path}identica.png" title="Identi.ca" alt="Identi.ca" class="socialbkmark" /></a>
---
> <a rel="nofollow" href="http://identi.ca/notice/new?status_textarea={$entrydata.title|escape:url}%20-%20{$entrydata.url|escape:url}" title=Identi.ca"><img src="{$entrydata.path}identica.png" title="Identi.ca" alt="Identi.ca" class="socialbkmark" /></a>
Re: Diff for identi.ca in serendipity_event_findmore
Posted: Sat Jun 11, 2011 10:49 am
by garvinhicking
Hi!
I changed the missing " for identica. I don't understand what's with the Twitter change? rel=nofollow is already there?!?
Regards,
Garvin
Re: Diff for identi.ca in serendipity_event_findmore
Posted: Sat Jun 11, 2011 11:00 am
by seraphyn
rel=nofollow is for the img source and not for the link.
<img src="{$entrydata.path}twitter.png" title="Twitter" alt="Twitter" rel="nofollow"
but it have to be
<a rel="nofollow" href="
http://twitter.com/home?status={$entryd ... escape:url}"
So this works with validator from w3c too and have more sense
Chris
Re: Diff for identi.ca in serendipity_event_findmore
Posted: Sun Jun 12, 2011 12:33 pm
by garvinhicking
Hi!
ah sorry! Now I see! Also committed.
Re: Diff for identi.ca in serendipity_event_findmore
Posted: Sun Jun 12, 2011 12:50 pm
by seraphyn
You're welcome.
Thanks
Have a nice Weekend and Pfingsten
Chris
Re: Diff for identi.ca in serendipity_event_findmore
Posted: Tue Sep 20, 2011 1:37 pm
by Marit321
Hi,
why do you use rel=nofollow for the img source ?
<a rel="nofollow" href="
http://twitter.com/home?status={$entryd ... escape:url}"
Thank´s
Marit
------------------------------------
my sites:
Private Krankenversicherung
Private Krankenversicherung Vergleich
Re: Diff for identi.ca in serendipity_event_findmore
Posted: Tue Sep 20, 2011 1:53 pm
by seraphyn
Not for img-source, for the link.
Read above