Diff for identi.ca in serendipity_event_findmore

[seraphyn]

plugin_findmore.tpl:

Code: Select all

8,12d7
< 
< {if NOT $findmore_disabled_services.identica}
< <a href="http://identi.ca/notice/new?status_textarea={$entrydata.title|escape:url}%20-%20{$entrydata.url|escape:url}" title=Identi.ca"><img src="{$entrydata.path}identica.png" title="Identi.ca" alt="Identi.ca" class="socialbkmark" /></a>
< {/if}
< 

serendipity_event_findmore.php

Code: Select all

76a77
>                         'identica'       => 'Identi.ca',

Identi.ca-Pic attached

[garvinhicking]

Hi!

Great! Added to CVS.

Regards,
Garvin

[seraphyn]

Hi Garvin,

one Error:

[quote="seraphyn"]plugin_findmore.tpl:

Code: Select all

8,12d7
< 
< {if NOT $findmore_disabled_services.identica}
< <a href="http://identi.ca/notice/new?status_textarea={$entrydata.title|escape:url}%20-%20{$entrydata.url|escape:url}" title=Identi.ca"><img src="{$entrydata.path}identica.png" title="Identi.ca" alt="Identi.ca" class="socialbkmark" /></a>
< {/if}
< 

title =identi.ca" is wrong.
There should be an ".
Did you need a new diff?

chris

[seraphyn]

Garinv,

diff including the wrong set in twitter for rel="nofollow" and identi.ca wrong title:
plugin_findmore.tpl:

Code: Select all

5c5
< <a  rel="nofollow" href="http://twitter.com/home?status={$entrydata.title|escape}%20-%20{$entrydata.url|escape:url}" title="Twitter"><img src="{$entrydata.path}twitter.png" title="Twitter" alt="Twitter" class="socialbkmark" /></a>
---
> <a href="http://twitter.com/home?status={$entrydata.title|escape}%20-%20{$entrydata.url|escape:url}" title="Twitter"><img src="{$entrydata.path}twitter.png" title="Twitter" alt="Twitter" rel="nofollow" class="socialbkmark" /></a>
105c105
< <a rel="nofollow" href="http://identi.ca/notice/new?status_textarea={$entrydata.title|escape:url}%20-%20{$entrydata.url|escape:url}" title="Identi.ca"><img src="{$entrydata.path}identica.png" title="Identi.ca" alt="Identi.ca" class="socialbkmark" /></a>
---
> <a rel="nofollow" href="http://identi.ca/notice/new?status_textarea={$entrydata.title|escape:url}%20-%20{$entrydata.url|escape:url}" title=Identi.ca"><img src="{$entrydata.path}identica.png" title="Identi.ca" alt="Identi.ca" class="socialbkmark" /></a>

[garvinhicking]

Hi!

I changed the missing " for identica. I don't understand what's with the Twitter change? rel=nofollow is already there?!?

Regards,
Garvin

[seraphyn]

rel=nofollow is for the img source and not for the link.
<img src="{$entrydata.path}twitter.png" title="Twitter" alt="Twitter" rel="nofollow"
but it have to be
<a rel="nofollow" href="http://twitter.com/home?status={$entryd ... escape:url}"
So this works with validator from w3c too and have more sense
Chris

[garvinhicking]

Hi!

ah sorry! Now I see! Also committed.

[seraphyn]

You're welcome.
Thanks
Have a nice Weekend and Pfingsten
Chris

[Marit321]

Hi,
why do you use rel=nofollow for the img source ?
<a rel="nofollow" href="http://twitter.com/home?status={$entryd ... escape:url}"
Thank´s
Marit


------------------------------------
my sites: Private Krankenversicherung
Private Krankenversicherung Vergleich

[seraphyn]

Not for img-source, for the link.
Read above