guestbook options

Creating and modifying plugins.
Post Reply
n2ition
Regular
Posts: 58
Joined: Sun Mar 20, 2005 8:43 pm
Location: Dallas, TX
Contact:

guestbook options

Post by n2ition »

I installed the guestbook on my site and really liked it until I realized that the posters e-mail address was not only available to every spambot on the planet but was in plain site for all other viewers. Is there anyway to allow people to post their e-mail addresses with their entries but only have them visible to admin? Most people post to the comments section but for those who just want to say "hi" I would like the option to respect their privacy and not advertise to the entire world what their e-mail address is.

Thanks for your help!
The good news is the bad news is wrong! Random Kindness Project
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: guestbook options

Post by garvinhicking »

I've just committed a fix for this so that you can configure whether to hide the email adresses or not.

Note that I did not develop the plugin, so I hope my changes work, since I do not use the plugin itself :)

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
n2ition
Regular
Posts: 58
Joined: Sun Mar 20, 2005 8:43 pm
Location: Dallas, TX
Contact:

Post by n2ition »

I have reinstalled the guestbook and the email option is working just fine...however all the entries are running together (no space between each entry), all the entries on the page are all numbered 1 and the entry number is on the last line of the post rather than the first. (?) (see it here)

Another suggeston would be regarding the actual layout of the entires themselves. Having the persons name and date posted all on one line or at least the same font size (smaller than the post) would be a bit nicer that large name, small date, large post...all run together. Having this page integrate with the css page so that it mimics the posting format on the blog itself would be ideal

Anyway those are my bugs and suggestions. Garvin, thanks for the change regarding e-mail addresses. I'll leave the current guestbook up for a while *if* you have time and inclination to look at the layout and see the issues you can. Otherwise I will probably pull it down in a couple of days until after a new version comes out or I decide to just go with a "standard" guestbook not integrated with s9y.
The good news is the bad news is wrong! Random Kindness Project
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi n2ition!

Hm, I just looked at your guestbook page, it looks alright? It's number properly, and the entries are separated with spacings?!?

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
n2ition
Regular
Posts: 58
Joined: Sun Mar 20, 2005 8:43 pm
Location: Dallas, TX
Contact:

Post by n2ition »

hmmm, very strange IE shows both posts as #1 and all three browers (IE Foxfire & Opera) run the entries together rather than putting space between them. Here's screenshots

Internet Explorer
Image
Firefox
Image
Opera
Image

I know it would be great to just forget about IE because it is such a pain in the a$$ but the fact is around 90% of the readers of my blog use IE...so I have to cater to them.

Any suggestions on what I can do?
The good news is the bad news is wrong! Random Kindness Project
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Oka,y I only checked with firefox.

The IE just stumbled across some CSS instructions, stupid browser. I just fixed this in CVS and version 1.22 of the plugin.

Anyways, you can easily add spacing between the items with this CSS:

Code: Select all

.commentlist li {
margin-bottom: 15px !important;
}
Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
n2ition
Regular
Posts: 58
Joined: Sun Mar 20, 2005 8:43 pm
Location: Dallas, TX
Contact:

Post by n2ition »

am I blind? The latest CVS update I am seeing is showing the last update effective 12+ hours ago (that's the one that you did to hide e-mail addresses). I went ahead and download it just in case...but I'm still having the same issue with IE...GRRRRRRR
The good news is the bad news is wrong! Random Kindness Project
n2ition
Regular
Posts: 58
Joined: Sun Mar 20, 2005 8:43 pm
Location: Dallas, TX
Contact:

Post by n2ition »

nevermind...I just got fed up enought to change the <ol> tag to <ul> and get rid of the numbers altogether. If and when you have time to deal with that headache go ahead...but I like it better without the numbers anyway.

Thanks Garvin for all your help. As usual you are AWSOME!!!
The good news is the bad news is wrong! Random Kindness Project
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

SF.Net lags about 24hours, so my latest patch was not yet contained. Try again now :)

Regards
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
n2ition
Regular
Posts: 58
Joined: Sun Mar 20, 2005 8:43 pm
Location: Dallas, TX
Contact:

Post by n2ition »

Thanks for letting me know. I updated it just so I would have the latest copy...but wound up chaning the <ol> to <ul> anyway. :)
The good news is the bad news is wrong! Random Kindness Project
Post Reply