findmore plugin needs update

Creating and modifying plugins.
Post Reply
Noelb
Regular
Posts: 59
Joined: Wed Jul 27, 2011 7:16 am

findmore plugin needs update

Post by Noelb » Thu Jun 10, 2021 1:31 pm

Hi,
This plugin uses http when linking to twitter facebook etc, all these need to be moved to https

some browsers throw ssl alerts and block/hide the links because insecure (http content from https site)

Garvin, I've manually changed a couple of these after eventually also finding the tpl in templates I think it was as changing in the plugin did nothing, either way I expect these wiped out on next update, could we get this plugin fixed so we dont need to make manual mods please?

Cheers

User avatar
onli
Regular
Posts: 2522
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: findmore plugin needs update

Post by onli » Thu Jun 10, 2021 4:50 pm

Hi,
The findmore plugin got moved to https://github.com/s9y/additional_plugi ... ster/alpha a while ago, which signals it got abandoned. I don't remember that properly, but I think it was about it having no maintainer and too many services listed that don't exist anymore.

We do have a current alternative: serendipity_event_social (Share Buttons). It uses a legal, privacy preserving alternative to the old share buttons. I have it enabled in my blog if you want to have a look.
could we get this plugin fixed so we dont need to make manual mods please?
If you'd like to work on the plugin, you could send a pull request with your changes to https://github.com/s9y/additional_plugins . But it being moved out of the main path should mean that you do not have to worry much about updates overwriting your changes (though it will need fixes to work with PHP 8, not sure how this will be solved).

Noelb
Regular
Posts: 59
Joined: Wed Jul 27, 2011 7:16 am

Re: findmore plugin needs update

Post by Noelb » Fri Jun 11, 2021 6:00 am

Ohhh, OK, I'll have to check timestamps but it might be removed for new installs, it still shows on existing installs after upgrades, still lists Garvin as its maintainer :)

User avatar
onli
Regular
Posts: 2522
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: findmore plugin needs update

Post by onli » Fri Jun 11, 2021 8:21 am

Yeah, I'm sure we didn't remove it for old installs. That's something I can only imagine for an emergency, as in a plugin breaking new versions of s9y/PHP8 or being completely insecure.

Not your fault! :)

Noelb
Regular
Posts: 59
Joined: Wed Jul 27, 2011 7:16 am

Re: findmore plugin needs update

Post by Noelb » Thu Jun 17, 2021 2:26 am

I've moved to using the share plugin, looks nicer ;)

One thing though.. I found if we disable buttons using "none" it ignores the dont show on main page. But enabled buttons as looks better, is there a reason the buttons are loaded from a third party site and not included in the package?
(counters are not required by here)

I also see it overrides/hides the old findmore as well, but I disabled the old one just to be sure

User avatar
onli
Regular
Posts: 2522
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: findmore plugin needs update

Post by onli » Thu Jun 17, 2021 4:16 pm

Noelb wrote:
Thu Jun 17, 2021 2:26 am
I found if we disable buttons using "none" it ignores the dont show on main page.
Do you mean the option for the backend, to disable the counter?
Noelb wrote:
Thu Jun 17, 2021 2:26 am
is there a reason the buttons are loaded from a third party site and not included in the package?
If I'm not missing something, the plugin is not loading a button from a third party. It is using a third party to get the share count of the articles. With a server in between your visitors browser and those services you do not leak your visitors information.

If you want you can host that shariff backend yourself, it does not have to be the one I host for the plugin :) https://github.com/heiseonline/shariff-backend-php is the backend used.

Noelb
Regular
Posts: 59
Joined: Wed Jul 27, 2011 7:16 am

Re: findmore plugin needs update

Post by Noelb » Fri Jun 18, 2021 4:26 am

onli wrote:
Thu Jun 17, 2021 4:16 pm
Noelb wrote:
Thu Jun 17, 2021 2:26 am
I found if we disable buttons using "none" it ignores the dont show on main page.
Do you mean the option for the backend, to disable the counter?
Noelb wrote:
Thu Jun 17, 2021 2:26 am
is there a reason the buttons are loaded from a third party site and not included in the package?
If I'm not missing something, the plugin is not loading a button from a third party. It is using a third party to get the share count of the articles. With a server in between your visitors browser and those services you do not leak your visitors information.

If you want you can host that shariff backend yourself, it does not have to be the one I host for the plugin :) https://github.com/heiseonline/shariff-backend-php is the backend used.
Ahh OK, thanks for clarification. I'm not overly concerned but I have some paranoid users :)

As for previous, yes, I found for me, the findmore was interfering with it if it wasnt disabled, if set the counter link to none with show on preview pages as no it showed hyperlinks "alt" on main page as well as full particle - but removing findmore seems to have fixed it, so it's all good now.

Post Reply