Bugreport for Plugin Wikipedia Finder version 1.2

[hagenroewer]

HTML-Mistake in form tag

Source Code:

Code: Select all

<div align='center'><form id='wikipediafinderform' 
                    action='http://de.wikipedia.org/wiki/Spezial:Search' method='get' 
                    style='margin-bottom:0px;'  <input type='hidden' name='search' value='' id='wikipediafinder' />
                <input onmousedown='      getSelectedText(); return false;' 
                    onclick='return false;'
                    type='image' style='height:30px; width:31px;' 
                    src='http://www.soliblog.de/plugins/serendipity_plugin_wikipedia_finder/wikipedia_black.gif' /><br />
                Ein Markiertes Wort in Wikipedia suchen
            </form></div>

Firefox Extension "HTMl Validator" reports

Zeile 370 Zeichen 38 - Warnung: <form> missing '>' for end of tag

[garvinhicking]

Hi!

Thanks a lot for your verbose bug report! However, the " />" in the <input> element was correct. What was buggy though was that the closing ">" of the <form> tag was not outputted in cases where you did not configure the use of a 'target' element.

I just committed a fix so that the closing '>' is always emitted, and thus fixing the symtpom of it.

Many thanks for helping to improve Serendipity!

Best regards,
Garvin

[hagenroewer]

Hi Garvin,

i have a fix:

In file serendipity_plugin_wikipedia_finder.php type after Line 128 a new line 129 with code

Code: Select all

else echo ">";