Bug in embedding

Found a bug? Tell us!!
Post Reply
Guest

Bug in embedding

Post by Guest » Mon Nov 03, 2003 7:14 pm

Setting $serendipity['embed'] to true results in a bug in the following code:

if (!$serendipity['embed'] || $serendipity['embed'] == 'false' || $serendipity['embed'] === false) {

from http://us3.php.net/manual/en/types.comparisons.php ,

it is true that (TRUE == 'false' ) but it is false that (TRUE === 'false')

so the second term hits, and the code is never embedded.

This code is all over the place.

Post Reply